Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rewrite rtdb in typescript, using apiv2 #4568

Merged
merged 2 commits into from May 19, 2022
Merged

rewrite rtdb in typescript, using apiv2 #4568

merged 2 commits into from May 19, 2022

Conversation

bkendall
Copy link
Contributor

Description

Rewrite rtdb.js to typescript, using apiv2.

Fixes #4083

Scenarios Tested

Tested deploying rules, both valid an invalid.

src/rtdb.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@joehan joehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one nit

@bkendall bkendall enabled auto-merge (squash) May 19, 2022 20:04
@bkendall bkendall merged commit cb8afa8 into master May 19, 2022
@bkendall bkendall deleted the bk-rtdb branch May 19, 2022 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert to TS: src/rtdb.js
2 participants