Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide runtime config in Node discovery #4541

Merged
merged 3 commits into from May 11, 2022
Merged

Provide runtime config in Node discovery #4541

merged 3 commits into from May 11, 2022

Conversation

inlined
Copy link
Member

@inlined inlined commented May 11, 2022

We can't deprecate Runtime Config fully yet =/

@inlined inlined requested a review from colerogers May 11, 2022 16:25
@inlined
Copy link
Member Author

inlined commented May 11, 2022

Fixes #4538

colerogers
colerogers approved these changes May 11, 2022
View reviewed changes
Copy link
Contributor

@colerogers colerogers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@bkendall bkendall merged commit 4b2242e into master May 11, 2022
@bkendall bkendall deleted the inlined.discovery-config branch May 11, 2022 16:44
@anantakrishna anantakrishna mentioned this pull request Jun 4, 2022
Closed
@anantakrishna anantakrishna mentioned this pull request Jun 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colerogers colerogers colerogers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@inlined @colerogers @bkendall