Fix memory options for some functions #3924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taeold
approved these changes
Nov 30, 2021
src/gcp/cloudfunctionsv2.ts
Outdated
| @@ -163,6 +163,40 @@ interface GenerateUploadUrlResponse { | |||
| storageSource: StorageSource; | |||
| } | |||
|
|
|||
| // AvailableMemory suffixes and their byte count. | |||
| type MemoryUnit = "" | "k" | "M" | "G" | "Mi" | "Gi"; | |||
There was a problem hiding this comment.
Are we skipping Ki b/c we don't think it's a popular choice? It looks like Cloud Run supports several more units, and our code will fail if the customer decides to use a unit not in this list.
There was a problem hiding this comment.
From the GCF proto, it looks like Ki is not a supported unit at this time.
There was a problem hiding this comment.
I can just extend this to support more than GCF supports pretty easily.
devpeerapong
pushed a commit
to devpeerapong/firebase-tools
that referenced
this pull request
Dec 14, 2021
* Fix memory options for some functions * Add additional units for futureproofing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For context, see alpha tester report