Fix bug where CLI would crash when customers upload an empty functions project #3705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taeold
approved these changes
Aug 25, 2021
colerogers
pushed a commit
that referenced
this pull request
Sep 7, 2021
…s project (#3705) * Fix bug where CLI would crash when customers upload an empty functions project * Changelog
colerogers
added a commit
that referenced
this pull request
Sep 8, 2021
* PoC initial api calls * moving list functionality into helper method and added unit tests * update changelog * fix lint * adding jsdoc comment * Remove HttpsTrigger.allowInsecure (#3733) * Remove HttpsTrigger.allowInsecure * Formatter * Create new endpoint type definition (#3731) * Create new endpoint type definition * Fix build breaks * Remove HttpsTrigger.allowInsecure * Formatter * Add type discrimiation functions and fix break * Fix bug where CLI would crash when customers upload an empty functions project (#3705) * Fix bug where CLI would crash when customers upload an empty functions project * Changelog * Add support for --non-interactive to ext:install, and support updating existing instances (#3710) * started adding noninteractive support to ext:install * Refactoring ext-install to support non-interactive runs and offer updates to existing instances * self review * pr fixes * update changelog * moving list function to backend and table creation to command, added unit tests for comparing functions * adding listFunctions.ts back and move compare functions to backend * Update CHANGELOG.md Co-authored-by: Bryan Kendall <bkend@google.com> * fixing pr comments Co-authored-by: Thomas Bouldin <inlined@users.noreply.github.com> Co-authored-by: joehan <joehanley@google.com> Co-authored-by: Bryan Kendall <bkend@google.com>
devpeerapong
pushed a commit
to devpeerapong/firebase-tools
that referenced
this pull request
Dec 14, 2021
…s project (firebase#3705) * Fix bug where CLI would crash when customers upload an empty functions project * Changelog
devpeerapong
pushed a commit
to devpeerapong/firebase-tools
that referenced
this pull request
Dec 14, 2021
* PoC initial api calls * moving list functionality into helper method and added unit tests * update changelog * fix lint * adding jsdoc comment * Remove HttpsTrigger.allowInsecure (firebase#3733) * Remove HttpsTrigger.allowInsecure * Formatter * Create new endpoint type definition (firebase#3731) * Create new endpoint type definition * Fix build breaks * Remove HttpsTrigger.allowInsecure * Formatter * Add type discrimiation functions and fix break * Fix bug where CLI would crash when customers upload an empty functions project (firebase#3705) * Fix bug where CLI would crash when customers upload an empty functions project * Changelog * Add support for --non-interactive to ext:install, and support updating existing instances (firebase#3710) * started adding noninteractive support to ext:install * Refactoring ext-install to support non-interactive runs and offer updates to existing instances * self review * pr fixes * update changelog * moving list function to backend and table creation to command, added unit tests for comparing functions * adding listFunctions.ts back and move compare functions to backend * Update CHANGELOG.md Co-authored-by: Bryan Kendall <bkend@google.com> * fixing pr comments Co-authored-by: Thomas Bouldin <inlined@users.noreply.github.com> Co-authored-by: joehan <joehanley@google.com> Co-authored-by: Bryan Kendall <bkend@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue in https://twitter.com/bradwestfall/status/1430570730937229312.
Confirmed to work in test project.
The
preparephase previously early exited if there are no functions to deploy. Thereleasephase properly continues as long as functions is initialized instead, which caused it to crash when trying to create a deployment plan using the filters that weren't generated due toprepare's early exit. As a bonus, I cleaned up the upload code a bit to bypass uploads (or even prints that uploads are happening) if there are no functions to deploy.