normalize channel names on hosting:channel:create and remove hashes #2784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dahliasalem
reviewed
Nov 5, 2020
| @@ -160,7 +160,7 @@ export interface Version { | |||
| */ | |||
| export function normalizeName(s: string): string { | |||
| // Using a regex replaces *all* bad characters. | |||
| return s.replace(/[/:_]/g, "-"); | |||
| return s.replace(/[/:_#]/g, "-"); | |||
There was a problem hiding this comment.
Instead of "all bad characters" maybe specify which characters are being replaced
There was a problem hiding this comment.
The jsdoc comment is now updated to include #. But this comment is about using regex to replace the characters rather than another mechanism. I made it more specific.
dahliasalem
approved these changes
Nov 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2783
hosting:channel:deploydoes normalizing of the channel ID provided.:createwas not. Further, the normalization wasn't removing#from the provided IDs and causing issues when passed into a URL.Scenarios Tested
firebase hosting:channel:create test#barfirebase hosting:channel:deploy test#bar