From a45a8fc72502d46a3bd579bce901ba24cfd23a0c Mon Sep 17 00:00:00 2001 From: Sam Edson Date: Mon, 18 Oct 2021 15:29:01 -0400 Subject: [PATCH] Crashlytics fix cache directory on Windows (#3842) --- CHANGELOG.md | 1 + src/commands/crashlytics-symbols-upload.ts | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 96407484ff8..c55e0f00f4e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1 +1,2 @@ - Fix Auth Emulator deleteTenant not working with Node Admin (#3817). +- Fix Crashlytics Android Native Symbols not working on Windows due to ":" in the path (#3842) diff --git a/src/commands/crashlytics-symbols-upload.ts b/src/commands/crashlytics-symbols-upload.ts index 830130c911c..30caf5625a8 100644 --- a/src/commands/crashlytics-symbols-upload.ts +++ b/src/commands/crashlytics-symbols-upload.ts @@ -69,7 +69,8 @@ export default new Command("crashlytics:symbols:upload ") SYMBOL_CACHE_ROOT_DIR, `crashlytics-${uuid.v4()}`, "nativeSymbols", - app, + // Windows does not allow ":" in their directory names + app.replace(/:/g, "-"), generator ), symbolFile: "",