Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add createTime to Document. #6781

Merged
merged 10 commits into from Dec 2, 2022
Merged

Add createTime to Document. #6781

merged 10 commits into from Dec 2, 2022

Conversation

ehsannas
Copy link
Contributor

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Nov 10, 2022 •
edited

⚠️ No Changeset found

Latest commit: c80911d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ehsannas ehsannas self-assigned this Nov 10, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 10, 2022 •
edited

Changeset File Check ✅

  • No modified packages are missing from the changeset file.
  • No changeset formatting errors detected.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Nov 11, 2022 •
edited

Size Report 1

Affected Products

  • @firebase/analytics

    TypeBase (09dfc3a)Merge (0af8d2b)Diff
    browser20.2 kB20.1 kB-24 B (-0.1%)
    esm524.7 kB24.8 kB+89 B (+0.4%)
    main26.0 kB26.1 kB+89 B (+0.3%)
    module20.2 kB20.1 kB-24 B (-0.1%)

  • @firebase/app

    TypeBase (09dfc3a)Merge (0af8d2b)Diff
    browser14.4 kB14.3 kB-28 B (-0.2%)
    esm518.7 kB18.8 kB+103 B (+0.6%)
    main19.6 kB19.7 kB+103 B (+0.5%)
    module14.4 kB14.3 kB-28 B (-0.2%)

  • @firebase/app-check

    TypeBase (09dfc3a)Merge (0af8d2b)Diff
    browser25.2 kB25.2 kB+10 B (+0.0%)
    esm530.0 kB30.3 kB+230 B (+0.8%)
    main31.1 kB31.3 kB+230 B (+0.7%)
    module25.2 kB25.2 kB+10 B (+0.0%)

  • @firebase/auth

    TypeBase (09dfc3a)Merge (0af8d2b)Diff
    browser156 kB156 kB-92 B (-0.1%)
    cordova183 kB184 kB+330 B (+0.2%)
    esm5204 kB205 kB+441 B (+0.2%)
    main148 kB149 kB+266 B (+0.2%)
    module156 kB156 kB-92 B (-0.1%)
    react-native168 kB168 kB+301 B (+0.2%)

  • @firebase/auth-compat

    TypeBase (09dfc3a)Merge (0af8d2b)Diff
    browser20.2 kB20.2 kB-10 B (-0.0%)
    esm527.1 kB27.1 kB-10 B (-0.0%)
    main29.6 kB29.6 kB-10 B (-0.0%)
    module20.2 kB20.2 kB-10 B (-0.0%)

  • @firebase/auth/cordova

    TypeBase (09dfc3a)Merge (0af8d2b)Diff
    browser183 kB184 kB+330 B (+0.2%)
    module183 kB184 kB+330 B (+0.2%)

  • @firebase/auth/internal

    TypeBase (09dfc3a)Merge (0af8d2b)Diff
    browser167 kB167 kB-92 B (-0.1%)
    esm5218 kB218 kB+452 B (+0.2%)
    main184 kB184 kB+319 B (+0.2%)
    module167 kB167 kB-92 B (-0.1%)

  • @firebase/auth/react-native

    TypeBase (09dfc3a)Merge (0af8d2b)Diff
    browser168 kB168 kB+301 B (+0.2%)
    module168 kB168 kB+301 B (+0.2%)

  • @firebase/component

    TypeBase (09dfc3a)Merge (0af8d2b)Diff
    esm58.61 kB8.70 kB+87 B (+1.0%)
    main8.99 kB9.08 kB+87 B (+1.0%)

  • @firebase/database

    TypeBase (09dfc3a)Merge (0af8d2b)Diff
    esm5275 kB276 kB+223 B (+0.1%)
    main281 kB281 kB+223 B (+0.1%)

  • @firebase/database-compat/standalone

    TypeBase (09dfc3a)Merge (0af8d2b)Diff
    main369 kB370 kB+217 B (+0.1%)

  • @firebase/firestore

    TypeBase (09dfc3a)Merge (0af8d2b)Diff
    browser272 kB272 kB+292 B (+0.1%)
    esm5339 kB339 kB+279 B (+0.1%)
    main545 kB545 kB+510 B (+0.1%)
    module272 kB272 kB+292 B (+0.1%)
    react-native272 kB273 kB+292 B (+0.1%)

  • @firebase/firestore-lite

    TypeBase (09dfc3a)Merge (0af8d2b)Diff
    browser85.9 kB86.2 kB+301 B (+0.4%)
    esm5104 kB104 kB+310 B (+0.3%)
    main146 kB147 kB+511 B (+0.3%)
    module85.9 kB86.2 kB+301 B (+0.4%)
    react-native86.1 kB86.4 kB+301 B (+0.3%)

  • @firebase/functions

    TypeBase (09dfc3a)Merge (0af8d2b)Diff
    esm511.7 kB11.8 kB+117 B (+1.0%)
    main12.5 kB12.6 kB+117 B (+0.9%)

  • @firebase/installations

    TypeBase (09dfc3a)Merge (0af8d2b)Diff
    esm522.9 kB23.1 kB+104 B (+0.5%)
    main23.8 kB23.9 kB+104 B (+0.4%)

  • @firebase/logger

    TypeBase (09dfc3a)Merge (0af8d2b)Diff
    esm54.65 kB4.75 kB+98 B (+2.1%)
    main5.32 kB5.41 kB+98 B (+1.8%)

  • @firebase/messaging

    TypeBase (09dfc3a)Merge (0af8d2b)Diff
    browser21.4 kB21.4 kB-44 B (-0.2%)
    esm526.8 kB26.8 kB+42 B (+0.2%)
    main27.5 kB27.5 kB+42 B (+0.2%)
    module21.4 kB21.4 kB-44 B (-0.2%)

  • @firebase/messaging-sw

    TypeBase (09dfc3a)Merge (0af8d2b)Diff
    main30.2 kB30.2 kB+60 B (+0.2%)
    module23.4 kB23.4 kB-30 B (-0.1%)

  • @firebase/performance

    TypeBase (09dfc3a)Merge (0af8d2b)Diff
    esm530.8 kB31.0 kB+171 B (+0.6%)
    main31.3 kB31.5 kB+171 B (+0.5%)

  • @firebase/remote-config

    TypeBase (09dfc3a)Merge (0af8d2b)Diff
    esm524.0 kB24.1 kB+81 B (+0.3%)
    main25.2 kB25.3 kB+81 B (+0.3%)

  • @firebase/storage

    TypeBase (09dfc3a)Merge (0af8d2b)Diff
    esm562.3 kB62.5 kB+229 B (+0.4%)
    main58.5 kB58.5 kB-28 B (-0.0%)

  • @firebase/util

    TypeBase (09dfc3a)Merge (0af8d2b)Diff
    esm524.1 kB24.2 kB+112 B (+0.5%)
    main29.6 kB29.7 kB+112 B (+0.4%)

  • bundle

    43 size changes

    TypeBase (09dfc3a)Merge (0af8d2b)Diff
    analytics (logEvent)43.0 kB43.0 kB-36 B (-0.1%)
    app-check (CustomProvider)36.2 kB36.1 kB-46 B (-0.1%)
    app-check (ReCaptchaEnterpriseProvider)38.5 kB38.4 kB-46 B (-0.1%)
    app-check (ReCaptchaV3Provider)38.4 kB38.4 kB-46 B (-0.1%)
    auth (Anonymous)67.5 kB67.4 kB-70 B (-0.1%)
    auth (EmailAndPassword)71.6 kB71.5 kB-70 B (-0.1%)
    auth (GoogleFBTwitterGitHubPopup)93.9 kB93.8 kB-80 B (-0.1%)
    auth (GooglePopup)91.2 kB91.1 kB-80 B (-0.1%)
    auth (GoogleRedirect)91.4 kB91.3 kB-80 B (-0.1%)
    auth (Phone)77.6 kB77.6 kB-70 B (-0.1%)
    database (Append to a list of data)148 kB148 kB-20 B (-0.0%)
    database (Filtering data)147 kB147 kB-20 B (-0.0%)
    database (Listen for child events)163 kB163 kB-20 B (-0.0%)
    database (Listen for value events + Detach listeners)163 kB163 kB-20 B (-0.0%)
    database (Listen for value events)163 kB163 kB-20 B (-0.0%)
    database (Read data once)163 kB163 kB-20 B (-0.0%)
    database (Save data as transactions)165 kB165 kB-20 B (-0.0%)
    database (Sort data)148 kB148 kB-20 B (-0.0%)
    database (Write data)147 kB147 kB-20 B (-0.0%)
    firestore (Persistence)281 kB281 kB+217 B (+0.1%)
    firestore (Query Cursors)220 kB220 kB+130 B (+0.1%)
    firestore (Query)217 kB217 kB+130 B (+0.1%)
    firestore (Read data once)204 kB204 kB+130 B (+0.1%)
    firestore (Realtime updates)207 kB207 kB+130 B (+0.1%)
    firestore (Transaction)188 kB188 kB+124 B (+0.1%)
    firestore (Write data)188 kB188 kB+69 B (+0.0%)
    firestore-lite (Query Cursors)81.0 kB81.2 kB+226 B (+0.3%)
    firestore-lite (Query)77.2 kB77.4 kB+226 B (+0.3%)
    firestore-lite (Read data once)59.1 kB59.3 kB+238 B (+0.4%)
    firestore-lite (Transaction)83.7 kB84.0 kB+238 B (+0.3%)
    firestore-lite (Write data)68.9 kB68.9 kB-20 B (-0.0%)
    functions (call)30.9 kB30.9 kB-20 B (-0.1%)
    messaging (send + receive)46.4 kB46.3 kB-60 B (-0.1%)
    performance (trace)50.8 kB50.8 kB-20 B (-0.0%)
    remote-config (getAndFetch)45.4 kB45.3 kB-92 B (-0.2%)
    storage (getBytes)40.1 kB40.0 kB-20 B (-0.0%)
    storage (getDownloadURL)42.1 kB42.1 kB-20 B (-0.0%)
    storage (getMetadata)41.6 kB41.6 kB-20 B (-0.0%)
    storage (list + listAll)41.0 kB41.0 kB-20 B (-0.0%)
    storage (updateMetadata)41.8 kB41.8 kB-20 B (-0.0%)
    storage (uploadBytes)46.8 kB46.8 kB-20 B (-0.0%)
    storage (uploadBytesResumable)56.8 kB56.7 kB-20 B (-0.0%)
    storage (uploadString)47.0 kB47.0 kB-20 B (-0.0%)

  • firebase

    21 size changes

    TypeBase (09dfc3a)Merge (0af8d2b)Diff
    firebase-analytics-compat.js25.8 kB25.8 kB-30 B (-0.1%)
    firebase-analytics.js24.9 kB24.9 kB-42 B (-0.2%)
    firebase-app-check-compat.js22.7 kB22.6 kB-39 B (-0.2%)
    firebase-app-check.js21.4 kB21.3 kB-65 B (-0.3%)
    firebase-app-compat.js28.8 kB28.7 kB-26 B (-0.1%)
    firebase-app.js91.7 kB91.9 kB+260 B (+0.3%)
    firebase-auth-compat.js126 kB126 kB-104 B (-0.1%)
    firebase-auth-cordova.js137 kB138 kB+277 B (+0.2%)
    firebase-auth-react-native.js149 kB150 kB+391 B (+0.3%)
    firebase-auth.js117 kB117 kB-161 B (-0.1%)
    firebase-compat.js746 kB745 kB-102 B (-0.0%)
    firebase-firestore-compat.js319 kB320 kB+292 B (+0.1%)
    firebase-firestore-lite.js92.6 kB92.9 kB+301 B (+0.3%)
    firebase-firestore.js321 kB321 kB+292 B (+0.1%)
    firebase-messaging-compat.js38.3 kB38.2 kB-91 B (-0.2%)
    firebase-messaging-sw.js26.0 kB26.0 kB-69 B (-0.3%)
    firebase-messaging.js24.9 kB24.8 kB-92 B (-0.4%)
    firebase-performance-standalone-compat.es2017.js90.0 kB89.9 kB-46 B (-0.1%)
    firebase-performance-standalone-compat.js66.5 kB67.0 kB+538 B (+0.8%)
    firebase-remote-config-compat.js27.3 kB27.2 kB-104 B (-0.4%)
    firebase-remote-config.js26.4 kB26.3 kB-176 B (-0.7%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/VrPlhauezw.html

@ehsannas ehsannas assigned wu-hui and unassigned ehsannas Nov 11, 2022
@ehsannas ehsannas requested a review from wu-hui November 11, 2022 00:50
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Nov 11, 2022 •
edited

Size Analysis Report 1

This report is too large (147,575 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/iUNr4jI2du.html

@ehsannas ehsannas assigned ehsannas and unassigned wu-hui Nov 11, 2022
@ehsannas ehsannas assigned wu-hui and unassigned ehsannas Nov 24, 2022
wu-hui
wu-hui approved these changes Nov 29, 2022
View reviewed changes
Copy link
Contributor

@wu-hui wu-hui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two more tests requested, but LGTM so you can merge after adding them.

packages/firestore/test/unit/local/local_store.test.ts Show resolved Hide resolved
@wu-hui wu-hui assigned ehsannas and unassigned wu-hui Nov 29, 2022
@ehsannas ehsannas merged commit 649e7f3 into master Dec 2, 2022
@ehsannas ehsannas deleted the ehsann/store-create-time branch December 2, 2022 20:23
levino pushed a commit to levino/firebase-js-sdk that referenced this pull request Dec 10, 2022
@ehsannas @wu-hui @levino
Add createTime to Document. (firebase#6781)
1874dc9 
* Add createTime to Document.

* More createTime tests

* All tests pass except for Bundles tests.

* Don't use createTime in isEqual.

* getBaseDocument should always get results from remoteDocumentCache.

* Bring back tests.

* Add test that checks createTime gets updated after remote event.

* Add test for Set->RemoteEvent->Ack.

* try higher timeout.

Co-authored-by: Wu-Hui <wu.hui.github@gmail.com>
@firebase firebase locked and limited conversation to collaborators Jan 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wu-hui wu-hui wu-hui approved these changes

Assignees

@ehsannas ehsannas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ehsannas @google-oss-bot @wu-hui