Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add selenium-webdriver to devDependencies #6762

Merged
merged 2 commits into from Nov 28, 2022
Merged

Add selenium-webdriver to devDependencies #6762

merged 2 commits into from Nov 28, 2022

Conversation

prameshj
Copy link
Contributor

@prameshj prameshj commented Nov 7, 2022 •
edited

Fixes #6736

@changeset-bot
Copy link

changeset-bot bot commented Nov 7, 2022 •
edited

🦋 Changeset detected

Latest commit: 0bb85dd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/auth Patch
@firebase/auth-compat Patch
firebase Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Nov 7, 2022 •
edited

Size Report 1

Affected Products

No changes between base commit (e9fb403) and merge commit (046e10f).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/I7APPYWaNY.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Nov 7, 2022 •
edited

Size Analysis Report 1

Affected Products

No changes between base commit (e9fb403) and merge commit (046e10f).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/0EeYEZV5Fa.html

@prameshj prameshj marked this pull request as ready for review November 8, 2022 00:10
sam-gc
sam-gc approved these changes Nov 8, 2022
View reviewed changes
Copy link
Contributor

@sam-gc sam-gc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does compat have the same issue?

@prameshj
Copy link
Contributor Author

Does compat have the same issue?

good qn, i fixed compat as well.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 11, 2022 •
edited

Changeset File Check ⚠️

  • Warning: This PR modifies files in the following packages but they have not been included in the changeset file:

    • @firebase/auth-compat

    Make sure this was intentional.

@prameshj prameshj merged commit e650f64 into master Nov 28, 2022
@prameshj prameshj deleted the dev-deps branch November 28, 2022 20:41
@google-oss-bot google-oss-bot mentioned this pull request Dec 6, 2022
Merged
levino pushed a commit to levino/firebase-js-sdk that referenced this pull request Dec 10, 2022
@prameshj @levino
Add selenium-webdriver to devDependencies (firebase#6762)
35ac3fd 
* Add selenium-webdriver to devDependencies.

* changeset
@firebase firebase locked and limited conversation to collaborators Dec 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sam-gc sam-gc sam-gc approved these changes

@hsubox76 hsubox76 hsubox76 approved these changes

@avolkovi avolkovi Awaiting requested review from avolkovi

@lisajian lisajian Awaiting requested review from lisajian lisajian is a code owner

@yuchenshi yuchenshi Awaiting requested review from yuchenshi

@egilmorez egilmorez Awaiting requested review from egilmorez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@firebase/auth includes selenium-webdriver and tslib as dependencies
4 participants
@prameshj @google-oss-bot @sam-gc @hsubox76