Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo on changelog-generator #6758

Merged
merged 1 commit into from Nov 7, 2022
Merged

Typo on changelog-generator #6758

merged 1 commit into from Nov 7, 2022

Conversation

tbor00
Copy link
Contributor

@tbor00 tbor00 commented Nov 5, 2022

In this pr, fixed a typo in a variable name. It is a really very small change that does not affect any functionality or process.

@changeset-bot
Copy link

changeset-bot bot commented Nov 5, 2022

⚠️ No Changeset found

Latest commit: 6db86b4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-cla
Copy link

google-cla bot commented Nov 5, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@tbor00
Copy link
Contributor Author

tbor00 commented Nov 7, 2022

@dwyfrequency 👀

@dwyfrequency
Copy link
Contributor

@dwyfrequency 👀

updating in #6760

@tbor00
Copy link
Contributor Author

tbor00 commented Nov 7, 2022

@dwyfrequency 👀

updating in #6760

yes, I saw it but I would like to know why this contribution is not merge and another PR was made for it, I was reading in the contributors documentation and I found nothing about it.

it's just a doubt, don't take it the wrong way :)

dwyfrequency
dwyfrequency approved these changes Nov 7, 2022
View reviewed changes
Copy link
Contributor

@dwyfrequency dwyfrequency left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dwyfrequency
Copy link
Contributor

@dwyfrequency 👀

updating in #6760

yes, I saw it but I would like to know why this contribution is not merge and another PR was made for it, I was reading in the contributors documentation and I found nothing about it.

it's just a doubt, don't take it the wrong way :)

Feel free to merge once the required tests are done running

@tbor00
Copy link
Contributor Author

tbor00 commented Nov 7, 2022 •
edited

Would you help me to merge this PR? It looks like I don't have the necessary permissions to do it myself.
Sorry and thanks.

@dwyfrequency @hsubox76

@dwyfrequency dwyfrequency merged commit 6e666dc into firebase:master Nov 7, 2022
@dwyfrequency
Copy link
Contributor

Would you help me to merge this PR? It looks like I don't have the necessary permissions to do it myself. Sorry and thanks.

@dwyfrequency @hsubox76

Done! Thank you for the contribution

@firebase firebase locked and limited conversation to collaborators Dec 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dwyfrequency dwyfrequency dwyfrequency approved these changes

@hsubox76 hsubox76 Awaiting requested review from hsubox76

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tbor00 @dwyfrequency