Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix message id parsing #5881

Merged
merged 2 commits into from Jan 12, 2022
Merged

Fix message id parsing #5881

merged 2 commits into from Jan 12, 2022

Conversation

zwu52
Copy link
Member

@zwu52 zwu52 commented Jan 11, 2022

Message Id is passed down to the SDK as camel case as opposed to snake case.

The previous implementation resulted mid=null for all messages.

@zwu52 zwu52 requested a review from hsubox76 January 11, 2022 23:37
@changeset-bot
Copy link

changeset-bot bot commented Jan 11, 2022 •
edited

🦋 Changeset detected

Latest commit: 5cff20d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/messaging Patch
firebase Patch
@firebase/messaging-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 11, 2022 •
edited

Size Report 1

Affected Products

  • @firebase/messaging

    TypeBase (d0c8bfe)Merge (b83f595)Diff
    browser20.8 kB20.8 kB-2 B (-0.0%)
    esm526.1 kB26.1 kB-2 B (-0.0%)
    main26.8 kB26.8 kB-2 B (-0.0%)
    module20.8 kB20.8 kB-2 B (-0.0%)

  • @firebase/messaging-sw

    TypeBase (d0c8bfe)Merge (b83f595)Diff
    module22.8 kB22.8 kB-6 B (-0.0%)

  • bundle

    TypeBase (d0c8bfe)Merge (b83f595)Diff
    messaging (send + receive)37.8 kB37.8 kB-2 B (-0.0%)

  • firebase

    TypeBase (d0c8bfe)Merge (b83f595)Diff
    firebase-compat.js753 kB753 kB-8 B (-0.0%)
    firebase-messaging-compat.js38.0 kB37.9 kB-8 B (-0.0%)
    firebase-messaging-sw.js102 kB102 kB-6 B (-0.0%)
    firebase-messaging.js101 kB101 kB-2 B (-0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/6mEXudJsiS.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 12, 2022 •
edited

Size Analysis Report 1

Affected Products

  • @firebase/messaging

    • deleteToken

      Size

      TypeBase (d0c8bfe)Merge (b83f595)Diff
      size12.4 kB12.4 kB-2 B (-0.0%)
      size-with-ext-deps30.5 kB30.5 kB-2 B (-0.0%)

    • getMessaging

      Size

      TypeBase (d0c8bfe)Merge (b83f595)Diff
      size12.8 kB12.8 kB-2 B (-0.0%)
      size-with-ext-deps31.4 kB31.4 kB-2 B (-0.0%)

    • getToken

      Size

      TypeBase (d0c8bfe)Merge (b83f595)Diff
      size12.3 kB12.3 kB-2 B (-0.0%)
      size-with-ext-deps30.3 kB30.3 kB-2 B (-0.0%)

    • isSupported

      Size

      TypeBase (d0c8bfe)Merge (b83f595)Diff
      size12.6 kB12.6 kB-2 B (-0.0%)
      size-with-ext-deps31.1 kB31.1 kB-2 B (-0.0%)

    • onMessage

      Size

      TypeBase (d0c8bfe)Merge (b83f595)Diff
      size12.4 kB12.4 kB-2 B (-0.0%)
      size-with-ext-deps30.5 kB30.5 kB-2 B (-0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/xWUt9eGZW5.html

@zwu52 zwu52 requested a review from egilmorez as a code owner January 12, 2022 17:15
@zwu52 zwu52 merged commit 3c20727 into master Jan 12, 2022
@zwu52 zwu52 deleted the fix_mid branch January 12, 2022 17:47
@google-oss-bot google-oss-bot mentioned this pull request Jan 12, 2022
Merged
@firebase firebase locked and limited conversation to collaborators Feb 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hsubox76 hsubox76 hsubox76 approved these changes

@egilmorez egilmorez Awaiting requested review from egilmorez

Assignees

@hsubox76 hsubox76

@zwu52 zwu52

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zwu52 @google-oss-bot @hsubox76