Change FirestoreError to extend FirebaseError #5831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 30a30b8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 28 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
schmidt-sebastian
requested review from
allspain and
hsubox76
as code owners
Binary Size ReportAffected SDKs
Test Logs
|
…e-js-sdk into mrschmidt/firebaseerror
…e-js-sdk into mrschmidt/firebaseerror
hsubox76
approved these changes
Jan 4, 2022
| @@ -15,6 +14,9 @@ import { FirebaseError } from '@firebase/util'; | |||
| * See the License for the specific language governing permissions and | |||
| * limitations under the License. | |||
| */ | |||
|
|
|||
| import { FirebaseError } from '@firebase/util'; | |||
There was a problem hiding this comment.
Did the placement of this affect the build?
There was a problem hiding this comment.
No, I just cleaned it up.
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes FirestoreError to extend FirebaseError and updates the "Prune DTS" script to not remove this change again.
As part of this, I added a new test to "Prune DTS" and added a test runner for IntelliJ/WebStorm.
Fixes #5754