Add double to bit encoding for OrderedCode #5816
Conversation
|
schmidt-sebastian
force-pushed
the
mrschmidt/numbersonly
branch
from
8a4d444
to
ba2e33a
Compare
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1This report is too large (1361656 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.Test Logs |
| */ | ||
| private toOrderedBits(val: number): Uint8Array { | ||
| const value = doubleToLongBits(val); | ||
| const isNegative = (value[0] & 0x80) !== 0; |
There was a problem hiding this comment.
I'm curious why const isNegative = val < 0 is not used? Is it because of the three exceptions listed above?
There was a problem hiding this comment.
We are not actually looking at a number that is encoded as a long. Instead, we are looking at the first element of the byte array that is encoded as a number from 0 to 255.
There was a problem hiding this comment.
that's my question.. wouldn't it be easier to detect negativeness by checking the number (val) rather than checking the byte array (value)?
No action is needed though.
There was a problem hiding this comment.
We are checking whether the bit representation is "negative" not the number itself. Maybe the naming could use some improvement, but this is what the original implementation uses.
The tests fail if we just check if val is negative.
This ports the double encoding from https://github.com/firebase/firebase-android-sdk/blob/master/firebase-firestore/src/main/java/com/google/firebase/firestore/index/OrderedCodeWriter.java
Note that Android does not have tests for this code since it is just a copy of the backend code.