Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Auth] Add gmpid header #5799

Merged
merged 2 commits into from Dec 7, 2021
Merged

[Auth] Add gmpid header #5799

merged 2 commits into from Dec 7, 2021

Conversation

sam-gc
Copy link
Contributor

@sam-gc sam-gc commented Dec 7, 2021

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Dec 7, 2021

🦋 Changeset detected

Latest commit: 75a6871

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/auth Patch
@firebase/auth-compat Patch
firebase Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 7, 2021

Binary Size Report

Affected SDKs

  • @firebase/auth/cordova

    Type Base (931c80d) Head (87ec08b) Diff
    browser 179 kB 180 kB +552 B (+0.3%)
    module 179 kB 180 kB +552 B (+0.3%)
  • @firebase/auth/internal

    Type Base (931c80d) Head (87ec08b) Diff
    browser 163 kB 163 kB +95 B (+0.1%)
    esm5 212 kB 212 kB +552 B (+0.3%)
    main 179 kB 179 kB +598 B (+0.3%)
    module 163 kB 163 kB +95 B (+0.1%)
  • @firebase/auth/react-native

    Type Base (931c80d) Head (87ec08b) Diff
    browser 163 kB 163 kB +600 B (+0.4%)
    module 163 kB 163 kB +600 B (+0.4%)
  • bundle

    Type Base (931c80d) Head (87ec08b) Diff
    auth (Anonymous) 56.9 kB 57.0 kB +76 B (+0.1%)
    auth (EmailAndPassword) 61.0 kB 61.1 kB +76 B (+0.1%)
    auth (GoogleFBTwitterGitHubPopup) 80.7 kB 80.8 kB +76 B (+0.1%)
    auth (GooglePopup) 80.5 kB 80.6 kB +76 B (+0.1%)
    auth (GoogleRedirect) 80.7 kB 80.8 kB +76 B (+0.1%)
    auth (Phone) 66.9 kB 67.0 kB +76 B (+0.1%)
  • firebase

    Type Base (931c80d) Head (87ec08b) Diff
    firebase-auth-compat.js 123 kB 123 kB +76 B (+0.1%)
    firebase-auth.js 411 kB 411 kB +215 B (+0.1%)
    firebase-compat.js 753 kB 753 kB +75 B (+0.0%)

Test Logs

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 7, 2021

Size Analysis Report

Affected Products

  • @firebase/auth

    • ActionCodeURL

      Size Table

      TypeBase (931c80d)Head (87ec08b)Diff
      size
      30.9 kB
      31.0 kB
      +77 B (+0.2%)
      size-with-ext-deps
      43.0 kB
      43.1 kB
      +76 B (+0.2%)
    • AuthCredential

      Size Table

      TypeBase (931c80d)Head (87ec08b)Diff
      size
      30.1 kB
      30.2 kB
      +77 B (+0.3%)
      size-with-ext-deps
      42.0 kB
      42.1 kB
      +76 B (+0.2%)
    • EmailAuthCredential

      Size Table

      TypeBase (931c80d)Head (87ec08b)Diff
      size
      32.0 kB
      32.1 kB
      +77 B (+0.2%)
      size-with-ext-deps
      43.9 kB
      44.0 kB
      +76 B (+0.2%)
    • EmailAuthProvider

      Size Table

      TypeBase (931c80d)Head (87ec08b)Diff
      size
      33.4 kB
      33.5 kB
      +77 B (+0.2%)
      size-with-ext-deps
      45.6 kB
      45.6 kB
      +76 B (+0.2%)
    • FacebookAuthProvider

      Size Table

      TypeBase (931c80d)Head (87ec08b)Diff
      size
      35.0 kB
      35.1 kB
      +77 B (+0.2%)
      size-with-ext-deps
      46.9 kB
      47.0 kB
      +76 B (+0.2%)
    • GithubAuthProvider

      Size Table

      TypeBase (931c80d)Head (87ec08b)Diff
      size
      35.0 kB
      35.1 kB
      +77 B (+0.2%)
      size-with-ext-deps
      46.9 kB
      47.0 kB
      +76 B (+0.2%)
    • GoogleAuthProvider

      Size Table

      TypeBase (931c80d)Head (87ec08b)Diff
      size
      35.0 kB
      35.1 kB
      +77 B (+0.2%)
      size-with-ext-deps
      46.9 kB
      47.0 kB
      +76 B (+0.2%)
    • OAuthCredential

      Size Table

      TypeBase (931c80d)Head (87ec08b)Diff
      size
      32.1 kB
      32.2 kB
      +77 B (+0.2%)
      size-with-ext-deps
      44.0 kB
      44.1 kB
      +76 B (+0.2%)
    • OAuthProvider

      Size Table

      TypeBase (931c80d)Head (87ec08b)Diff
      size
      36.0 kB
      36.0 kB
      +77 B (+0.2%)
      size-with-ext-deps
      47.8 kB
      47.9 kB
      +76 B (+0.2%)
    • PhoneAuthCredential

      Size Table

      TypeBase (931c80d)Head (87ec08b)Diff
      size
      32.1 kB
      32.2 kB
      +77 B (+0.2%)
      size-with-ext-deps
      44.0 kB
      44.1 kB
      +76 B (+0.2%)
    • PhoneAuthProvider

      Size Table

      TypeBase (931c80d)Head (87ec08b)Diff
      size
      33.8 kB
      33.9 kB
      +77 B (+0.2%)
      size-with-ext-deps
      45.7 kB
      45.8 kB
      +76 B (+0.2%)
    • PhoneMultiFactorGenerator

      Size Table

      TypeBase (931c80d)Head (87ec08b)Diff
      size
      30.8 kB
      30.9 kB
      +77 B (+0.2%)
      size-with-ext-deps
      42.7 kB
      42.8 kB
      +76 B (+0.2%)
    • RecaptchaVerifier

      Size Table

      TypeBase (931c80d)Head (87ec08b)Diff
      size
      36.3 kB
      36.3 kB
      +77 B (+0.2%)
      size-with-ext-deps
      48.2 kB
      48.2 kB
      +76 B (+0.2%)
    • SAMLAuthProvider

      Size Table

      TypeBase (931c80d)Head (87ec08b)Diff
      size
      36.3 kB
      36.4 kB
      +77 B (+0.2%)
      size-with-ext-deps
      48.2 kB
      48.2 kB
      +76 B (+0.2%)
    • TwitterAuthProvider

      Size Table

      TypeBase (931c80d)Head (87ec08b)Diff
      size
      35.0 kB
      35.1 kB
      +77 B (+0.2%)
      size-with-ext-deps
      46.9 kB
      47.0 kB
      +76 B (+0.2%)
    • applyActionCode

      Size Table

      TypeBase (931c80d)Head (87ec08b)Diff
      size
      30.1 kB
      30.2 kB
      +77 B (+0.3%)
      size-with-ext-deps
      42.0 kB
      42.0 kB
      +76 B (+0.2%)
    • checkActionCode

      Size Table

      TypeBase (931c80d)Head (87ec08b)Diff
      size
      31.0 kB
      31.1 kB
      +77 B (+0.2%)
      size-with-ext-deps
      42.9 kB
      43.0 kB
      +76 B (+0.2%)
    • confirmPasswordReset

      Size Table

      TypeBase (931c80d)Head (87ec08b)Diff
      size
      30.1 kB
      30.2 kB
      +77 B (+0.3%)
      size-with-ext-deps
      42.0 kB
      42.1 kB
      +76 B (+0.2%)
    • connectAuthEmulator

      Size Table

      TypeBase (931c80d)Head (87ec08b)Diff
      size
      31.6 kB
      31.7 kB
      +77 B (+0.2%)
      size-with-ext-deps
      43.5 kB
      43.5 kB
      +76 B (+0.2%)
    • createUserWithEmailAndPassword

      Size Table

      TypeBase (931c80d)Head (87ec08b)Diff
      size
      31.0 kB
      31.1 kB
      +77 B (+0.2%)
      size-with-ext-deps
      42.9 kB
      42.9 kB
      +76 B (+0.2%)
    • deleteUser

      Size Table

      TypeBase (931c80d)Head (87ec08b)Diff
      size
      29.9 kB
      30.0 kB
      +77 B (+0.3%)
      size-with-ext-deps
      41.8 kB
      41.8 kB
      +76 B (+0.2%)
    • fetchSignInMethodsForEmail

      Size Table

      TypeBase (931c80d)Head (87ec08b)Diff
      size
      30.3 kB
      30.4 kB
      +77 B (+0.3%)
      size-with-ext-deps
      42.2 kB
      42.3 kB
      +76 B (+0.2%)
    • getAdditionalUserInfo

      Size Table

      TypeBase (931c80d)Head (87ec08b)Diff
      size
      31.2 kB
      31.3 kB
      +77 B (+0.2%)
      size-with-ext-deps
      43.1 kB
      43.1 kB
      +76 B (+0.2%)
    • getAuth

      Size Table

      TypeBase (931c80d)Head (87ec08b)Diff
      size
      61.9 kB
      61.9 kB
      +77 B (+0.1%)
      size-with-ext-deps
      74.4 kB
      74.5 kB
      +76 B (+0.1%)
    • getIdToken

      Size Table

      TypeBase (931c80d)Head (87ec08b)Diff
      size
      29.9 kB
      30.0 kB
      +77 B (+0.3%)
      size-with-ext-deps
      41.8 kB
      41.8 kB
      +76 B (+0.2%)
    • getIdTokenResult

      Size Table

      TypeBase (931c80d)Head (87ec08b)Diff
      size
      29.8 kB
      29.9 kB
      +77 B (+0.3%)
      size-with-ext-deps
      41.7 kB
      41.8 kB
      +76 B (+0.2%)
    • getMultiFactorResolver

      Size Table

      TypeBase (931c80d)Head (87ec08b)Diff
      size
      32.6 kB
      32.7 kB
      +77 B (+0.2%)
      size-with-ext-deps
      44.5 kB
      44.5 kB
      +76 B (+0.2%)
    • getRedirectResult

      Size Table

      TypeBase (931c80d)Head (87ec08b)Diff
      size
      37.5 kB
      37.6 kB
      +77 B (+0.2%)
      size-with-ext-deps
      49.4 kB
      49.5 kB
      +76 B (+0.2%)
    • initializeAuth

      Size Table

      TypeBase (931c80d)Head (87ec08b)Diff
      size
      30.1 kB
      30.2 kB
      +77 B (+0.3%)
      size-with-ext-deps
      42.3 kB
      42.4 kB
      +76 B (+0.2%)
    • isSignInWithEmailLink

      Size Table

      TypeBase (931c80d)Head (87ec08b)Diff
      size
      31.1 kB
      31.1 kB
      +77 B (+0.2%)
      size-with-ext-deps
      43.2 kB
      43.2 kB
      +76 B (+0.2%)
    • linkWithCredential

      Size Table

      TypeBase (931c80d)Head (87ec08b)Diff
      size
      30.9 kB
      31.0 kB
      +77 B (+0.2%)
      size-with-ext-deps
      42.8 kB
      42.8 kB
      +76 B (+0.2%)
    • linkWithPhoneNumber

      Size Table

      TypeBase (931c80d)Head (87ec08b)Diff
      size
      34.6 kB
      34.6 kB
      +77 B (+0.2%)
      size-with-ext-deps
      46.5 kB
      46.5 kB
      +76 B (+0.2%)
    • linkWithPopup

      Size Table

      TypeBase (931c80d)Head (87ec08b)Diff
      size
      41.1 kB
      41.2 kB
      +77 B (+0.2%)
      size-with-ext-deps
      53.0 kB
      53.1 kB
      +76 B (+0.1%)
    • linkWithRedirect

      Size Table

      TypeBase (931c80d)Head (87ec08b)Diff
      size
      36.3 kB
      36.4 kB
      +77 B (+0.2%)
      size-with-ext-deps
      48.2 kB
      48.2 kB
      +76 B (+0.2%)
    • multiFactor

      Size Table

      TypeBase (931c80d)Head (87ec08b)Diff
      size
      32.0 kB
      32.1 kB
      +77 B (+0.2%)
      size-with-ext-deps
      43.9 kB
      44.0 kB
      +76 B (+0.2%)
    • onAuthStateChanged

      Size Table

      TypeBase (931c80d)Head (87ec08b)Diff
      size
      29.9 kB
      30.0 kB
      +77 B (+0.3%)
      size-with-ext-deps
      41.8 kB
      41.9 kB
      +76 B (+0.2%)
    • onIdTokenChanged

      Size Table

      TypeBase (931c80d)Head (87ec08b)Diff
      size
      29.9 kB
      30.0 kB
      +77 B (+0.3%)
      size-with-ext-deps
      41.8 kB
      41.8 kB
      +76 B (+0.2%)
    • parseActionCodeURL

      Size Table

      TypeBase (931c80d)Head (87ec08b)Diff
      size
      31.0 kB
      31.1 kB
      +77 B (+0.2%)
      size-with-ext-deps
      43.1 kB
      43.2 kB
      +76 B (+0.2%)
    • reauthenticateWithCredential

      Size Table

      TypeBase (931c80d)Head (87ec08b)Diff
      size
      31.5 kB
      31.5 kB
      +77 B (+0.2%)
      size-with-ext-deps
      43.3 kB
      43.4 kB
      +76 B (+0.2%)
    • reauthenticateWithPhoneNumber

      Size Table

      TypeBase (931c80d)Head (87ec08b)Diff
      size
      35.1 kB
      35.2 kB
      +77 B (+0.2%)
      size-with-ext-deps
      47.0 kB
      47.1 kB
      +76 B (+0.2%)
    • reauthenticateWithPopup

      Size Table

      TypeBase (931c80d)Head (87ec08b)Diff
      size
      41.1 kB
      41.2 kB
      +77 B (+0.2%)
      size-with-ext-deps
      53.0 kB
      53.1 kB
      +76 B (+0.1%)
    • reauthenticateWithRedirect

      Size Table

      TypeBase (931c80d)Head (87ec08b)Diff
      size
      36.0 kB
      36.1 kB
      +77 B (+0.2%)
      size-with-ext-deps
      47.9 kB
      48.0 kB
      +76 B (+0.2%)
    • reload

      Size Table

      TypeBase (931c80d)Head (87ec08b)Diff
      size
      29.8 kB
      29.9 kB
      +77 B (+0.3%)
      size-with-ext-deps
      41.7 kB
      41.8 kB
      +76 B (+0.2%)
    • sendEmailVerification

      Size Table

      TypeBase (931c80d)Head (87ec08b)Diff
      size
      30.9 kB
      31.0 kB
      +77 B (+0.2%)
      size-with-ext-deps
      42.8 kB
      42.9 kB
      +76 B (+0.2%)
    • sendPasswordResetEmail

      Size Table

      TypeBase (931c80d)Head (87ec08b)Diff
      size
      30.8 kB
      30.9 kB
      +77 B (+0.2%)
      size-with-ext-deps
      42.7 kB
      42.8 kB
      +76 B (+0.2%)
    • sendSignInLinkToEmail

      Size Table

      TypeBase (931c80d)Head (87ec08b)Diff
      size
      30.9 kB
      30.9 kB
      +77 B (+0.2%)
      size-with-ext-deps
      42.7 kB
      42.8 kB
      +76 B (+0.2%)
    • setPersistence

      Size Table

      TypeBase (931c80d)Head (87ec08b)Diff
      size
      29.9 kB
      30.0 kB
      +77 B (+0.3%)
      size-with-ext-deps
      41.8 kB
      41.8 kB
      +76 B (+0.2%)
    • signInAnonymously

      Size Table

      TypeBase (931c80d)Head (87ec08b)Diff
      size
      31.1 kB
      31.2 kB
      +77 B (+0.2%)
      size-with-ext-deps
      43.0 kB
      43.1 kB
      +76 B (+0.2%)
    • signInWithCredential

      Size Table

      TypeBase (931c80d)Head (87ec08b)Diff
      size
      31.2 kB
      31.3 kB
      +77 B (+0.2%)
      size-with-ext-deps
      43.1 kB
      43.2 kB
      +76 B (+0.2%)
    • signInWithCustomToken

      Size Table

      TypeBase (931c80d)Head (87ec08b)Diff
      size
      31.0 kB
      31.1 kB
      +77 B (+0.2%)
      size-with-ext-deps
      42.9 kB
      42.9 kB
      +76 B (+0.2%)
    • signInWithEmailAndPassword

      Size Table

      TypeBase (931c80d)Head (87ec08b)Diff
      size
      34.9 kB
      35.0 kB
      +77 B (+0.2%)
      size-with-ext-deps
      47.0 kB
      47.1 kB
      +76 B (+0.2%)
    • signInWithEmailLink

      Size Table

      TypeBase (931c80d)Head (87ec08b)Diff
      size
      35.1 kB
      35.2 kB
      +77 B (+0.2%)
      size-with-ext-deps
      47.2 kB
      47.3 kB
      +76 B (+0.2%)
    • signInWithPhoneNumber

      Size Table

      TypeBase (931c80d)Head (87ec08b)Diff
      size
      34.9 kB
      35.0 kB
      +77 B (+0.2%)
      size-with-ext-deps
      46.8 kB
      46.9 kB
      +76 B (+0.2%)
    • signInWithPopup

      Size Table

      TypeBase (931c80d)Head (87ec08b)Diff
      size
      41.1 kB
      41.2 kB
      +77 B (+0.2%)
      size-with-ext-deps
      53.0 kB
      53.0 kB
      +76 B (+0.1%)
    • signInWithRedirect

      Size Table

      TypeBase (931c80d)Head (87ec08b)Diff
      size
      35.7 kB
      35.8 kB
      +77 B (+0.2%)
      size-with-ext-deps
      47.6 kB
      47.7 kB
      +76 B (+0.2%)
    • signOut

      Size Table

      TypeBase (931c80d)Head (87ec08b)Diff
      size
      29.9 kB
      30.0 kB
      +77 B (+0.3%)
      size-with-ext-deps
      41.7 kB
      41.8 kB
      +76 B (+0.2%)
    • unlink

      Size Table

      TypeBase (931c80d)Head (87ec08b)Diff
      size
      30.4 kB
      30.5 kB
      +77 B (+0.3%)
      size-with-ext-deps
      42.3 kB
      42.4 kB
      +76 B (+0.2%)
    • updateCurrentUser

      Size Table

      TypeBase (931c80d)Head (87ec08b)Diff
      size
      29.9 kB
      30.0 kB
      +77 B (+0.3%)
      size-with-ext-deps
      41.8 kB
      41.8 kB
      +76 B (+0.2%)
    • updateEmail

      Size Table

      TypeBase (931c80d)Head (87ec08b)Diff
      size
      30.2 kB
      30.2 kB
      +77 B (+0.3%)
      size-with-ext-deps
      42.0 kB
      42.1 kB
      +76 B (+0.2%)
    • updatePassword

      Size Table

      TypeBase (931c80d)Head (87ec08b)Diff
      size
      30.2 kB
      30.2 kB
      +77 B (+0.3%)
      size-with-ext-deps
      42.0 kB
      42.1 kB
      +76 B (+0.2%)
    • updatePhoneNumber

      Size Table

      TypeBase (931c80d)Head (87ec08b)Diff
      size
      30.6 kB
      30.7 kB
      +77 B (+0.3%)
      size-with-ext-deps
      42.5 kB
      42.6 kB
      +76 B (+0.2%)
    • updateProfile

      Size Table

      TypeBase (931c80d)Head (87ec08b)Diff
      size
      30.4 kB
      30.4 kB
      +77 B (+0.3%)
      size-with-ext-deps
      42.2 kB
      42.3 kB
      +76 B (+0.2%)
    • useDeviceLanguage

      Size Table

      TypeBase (931c80d)Head (87ec08b)Diff
      size
      29.9 kB
      30.0 kB
      +77 B (+0.3%)
      size-with-ext-deps
      41.8 kB
      41.8 kB
      +76 B (+0.2%)
    • verifyBeforeUpdateEmail

      Size Table

      TypeBase (931c80d)Head (87ec08b)Diff
      size
      30.9 kB
      31.0 kB
      +77 B (+0.2%)
      size-with-ext-deps
      42.8 kB
      42.9 kB
      +76 B (+0.2%)
    • verifyPasswordResetCode

      Size Table

      TypeBase (931c80d)Head (87ec08b)Diff
      size
      31.1 kB
      31.2 kB
      +77 B (+0.2%)
      size-with-ext-deps
      43.0 kB
      43.1 kB
      +76 B (+0.2%)
    • ActionCodeOperation

      Size Table

      TypeBase (931c80d)Head (87ec08b)Diff
      size
      30.1 kB
      30.2 kB
      +77 B (+0.3%)
      size-with-ext-deps
      42.0 kB
      42.0 kB
      +76 B (+0.2%)
    • AuthErrorCodes

      Size Table

      TypeBase (931c80d)Head (87ec08b)Diff
      size
      34.5 kB
      34.6 kB
      +77 B (+0.2%)
      size-with-ext-deps
      46.4 kB
      46.5 kB
      +76 B (+0.2%)
    • FactorId

      Size Table

      TypeBase (931c80d)Head (87ec08b)Diff
      size
      29.9 kB
      29.9 kB
      +77 B (+0.3%)
      size-with-ext-deps
      41.7 kB
      41.8 kB
      +76 B (+0.2%)
    • OperationType

      Size Table

      TypeBase (931c80d)Head (87ec08b)Diff
      size
      29.9 kB
      30.0 kB
      +77 B (+0.3%)
      size-with-ext-deps
      41.8 kB
      41.9 kB
      +76 B (+0.2%)
    • ProviderId

      Size Table

      TypeBase (931c80d)Head (87ec08b)Diff
      size
      30.0 kB
      30.1 kB
      +77 B (+0.3%)
      size-with-ext-deps
      41.8 kB
      41.9 kB
      +76 B (+0.2%)
    • SignInMethod

      Size Table

      TypeBase (931c80d)Head (87ec08b)Diff
      size
      30.0 kB
      30.1 kB
      +77 B (+0.3%)
      size-with-ext-deps
      41.9 kB
      41.9 kB
      +76 B (+0.2%)
    • browserLocalPersistence

      Size Table

      TypeBase (931c80d)Head (87ec08b)Diff
      size
      33.2 kB
      33.3 kB
      +77 B (+0.2%)
      size-with-ext-deps
      45.2 kB
      45.3 kB
      +76 B (+0.2%)
    • browserPopupRedirectResolver

      Size Table

      TypeBase (931c80d)Head (87ec08b)Diff
      size
      54.2 kB
      54.2 kB
      +77 B (+0.1%)
      size-with-ext-deps
      66.2 kB
      66.3 kB
      +76 B (+0.1%)
    • browserSessionPersistence

      Size Table

      TypeBase (931c80d)Head (87ec08b)Diff
      size
      33.2 kB
      33.3 kB
      +77 B (+0.2%)
      size-with-ext-deps
      45.2 kB
      45.3 kB
      +76 B (+0.2%)
    • debugErrorMap

      Size Table

      TypeBase (931c80d)Head (87ec08b)Diff
      size
      40.9 kB
      41.0 kB
      +77 B (+0.2%)
      size-with-ext-deps
      52.8 kB
      52.9 kB
      +76 B (+0.1%)
    • inMemoryPersistence

      Size Table

      TypeBase (931c80d)Head (87ec08b)Diff
      size
      29.9 kB
      29.9 kB
      +77 B (+0.3%)
      size-with-ext-deps
      41.7 kB
      41.8 kB
      +76 B (+0.2%)
    • indexedDBLocalPersistence

      Size Table

      TypeBase (931c80d)Head (87ec08b)Diff
      size
      37.3 kB
      37.4 kB
      +77 B (+0.2%)
      size-with-ext-deps
      49.2 kB
      49.2 kB
      +76 B (+0.2%)
    • prodErrorMap

      Size Table

      TypeBase (931c80d)Head (87ec08b)Diff
      size
      29.8 kB
      29.9 kB
      +77 B (+0.3%)
      size-with-ext-deps
      41.7 kB
      41.8 kB
      +76 B (+0.2%)

Copy link
Contributor

@lisajian lisajian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Is there an internal bug and/or issue associated with this change?

@sam-gc
Copy link
Contributor Author

sam-gc commented Dec 7, 2021

b/205577736

@lisajian
Copy link
Contributor

lisajian commented Dec 7, 2021

Thanks!

async _getAdditionalHeaders(): Promise<Record<string, string>> {
// Additional headers on every request
const headers: Record<string, string> = {
[HttpHeader.X_CLIENT_VERSION]: this.clientVersion,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this.clientVersion always non-empty and non-null? If unsure, please add a check. Empty header values may break emulators)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just moved code (the prior revision also always sends it). It's also always populated

@sam-gc sam-gc merged commit a777385 into master Dec 7, 2021
@sam-gc sam-gc deleted the sam-gc/appid branch December 7, 2021 22:45
@google-oss-bot google-oss-bot mentioned this pull request Dec 8, 2021
@firebase firebase locked and limited conversation to collaborators Jan 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants