Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bundle-size][auth] Refine bundle definition #5765

Merged
merged 1 commit into from Dec 4, 2021
Merged

Conversation

yifanyang
Copy link
Contributor

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Nov 30, 2021

⚠️ No Changeset found

Latest commit: 950c79b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-cla google-cla bot added the cla: yes label Nov 30, 2021
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Nov 30, 2021

Binary Size Report

Affected SDKs

  • bundle

    Type Base (086df7c) Head (204500e) Diff
    auth (GoogleFBTwitterGitHubPopup) 80.7 kB 80.7 kB -35 B (-0.0%)

Test Logs

@google-oss-bot
Copy link
Contributor

Size Analysis Report

Affected Products

No changes between base commit (086df7c) and head commit (204500e).

@yifanyang yifanyang changed the title [bundle-size] Refine bundle definition for Auth [bundle-size][auth] Refine bundle definition Dec 1, 2021
@yifanyang yifanyang requested a review from sam-gc December 2, 2021 19:51
@yifanyang
Copy link
Contributor Author

@Feiyang1 @hsubox76

Can I get one more approve from you to merge this pull request?

@yifanyang yifanyang assigned Feiyang1 and hsubox76 and unassigned sam-gc Dec 2, 2021
@Feiyang1 Feiyang1 assigned yifanyang and unassigned hsubox76 and Feiyang1 Dec 3, 2021
@yifanyang yifanyang merged commit 08da8c8 into master Dec 4, 2021
@yifanyang yifanyang deleted the yifany/bundle-auth branch December 4, 2021 00:43
@firebase firebase locked and limited conversation to collaborators Jan 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants