Skip to content

[Auth] Add compat integration tests to CI #5158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 15, 2021
Merged

[Auth] Add compat integration tests to CI #5158

merged 3 commits into from
Jul 15, 2021
+7 −5

Conversation

sam-gc
Copy link
Contributor

@sam-gc sam-gc commented Jul 15, 2021

Also fix those integration tests which had broken, fix a bug that the integration tests would have caught :P

@sam-gc sam-gc requested review from Feiyang1 and yuchenshi July 15, 2021 21:10
@sam-gc sam-gc requested a review from avolkovi as a code owner July 15, 2021 21:10
@changeset-bot
Copy link

changeset-bot bot commented Jul 15, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: 6e74b6c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

Changeset File Check ⚠️

  • Changeset formatting error in following file: 
    Package "firebase-compat-typings-test" must depend on the current version of "firebase-exp": "9.0.0-beta.6" vs "file:../../packages-exp/firebase-exp"
Package "firebase-compat-typings-test" must depend on the current version of "firebase-exp": "9.0.0-beta.6" vs "file:../../packages-exp/firebase-exp"
Package "firebase-compat-typings-test" must depend on the current version of "firebase-exp": "9.0.0-beta.6" vs "file:../../packages-exp/firebase-exp"
Some packages have been changed but no changesets were found. Run `changeset add` to resolve this error.
If this change doesn't need a release, run `changeset add --empty`.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 15, 2021 •
edited
Loading

Binary Size Report

Affected SDKs

No changes between base commit (d1ae4de) and head commit (62c58ba).

Test Logs

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 15, 2021 •
edited
Loading

Size Analysis Report

Affected Products

No changes between base commit (d1ae4de) and head commit (62c58ba).

yuchenshi
yuchenshi approved these changes Jul 15, 2021
View reviewed changes
@sam-gc @yuchenshi
Prefix project name with demo-

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
6e74b6c 
Co-authored-by: Yuchen Shi <yuchenshi@google.com>
@sam-gc sam-gc merged commit 4cb5d8a into master Jul 15, 2021
@sam-gc sam-gc deleted the sam-gc/compat-integration branch July 15, 2021 22:38
@firebase firebase locked and limited conversation to collaborators Aug 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yuchenshi yuchenshi

@Feiyang1 Feiyang1

@avolkovi avolkovi

Assignees

@Feiyang1 Feiyang1

@yuchenshi yuchenshi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sam-gc @google-oss-bot @yuchenshi @Feiyang1