Update grpc-js to 1.3

[schmidt-sebastian]

Updates minimum GRPC version to 1.3.

Fixes #4851

[changeset-bot]

⚠️ No Changeset found

Latest commit: f559936

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[google-oss-bot]

Binary Size Report

Affected SDKs

• firebase

  Click to show 15 binary size changes.

  Type	Base (a285f37)	Head (c383ee1)	Diff
  firebase-analytics.js	35.8 kB	35.7 kB	-16 B (-0.0%)
  firebase-app-check.js	22.2 kB	22.2 kB	-34 B (-0.2%)
  firebase-app.js	21.8 kB	21.8 kB	-42 B (-0.2%)
  firebase-auth.js	177 kB	177 kB	-21 B (-0.0%)
  firebase-database.js	187 kB	187 kB	-128 B (-0.1%)
  firebase-firestore.js	332 kB	332 kB	-75 B (-0.0%)
  firebase-firestore.memory.js	267 kB	267 kB	-63 B (-0.0%)
  firebase-functions.js	10.8 kB	10.8 kB	+4 B (+0.0%)
  firebase-installations.js	19.3 kB	19.3 kB	+5 B (+0.0%)
  firebase-messaging.js	41.0 kB	40.9 kB	-100 B (-0.2%)
  firebase-performance-standalone.js	49.7 kB	49.6 kB	-48 B (-0.1%)
  firebase-performance.js	38.3 kB	38.3 kB	-6 B (-0.0%)
  firebase-remote-config.js	36.9 kB	36.9 kB	+5 B (+0.0%)
  firebase-storage.js	41.6 kB	41.5 kB	-56 B (-0.1%)
  firebase.js	889 kB	888 kB	-405 B (-0.0%)

Test Logs

• Base (a285f37c): https://github.com/firebase/firebase-js-sdk/actions/runs/855033573
• Head (c383ee16): https://github.com/firebase/firebase-js-sdk/actions/runs/857985543

[google-oss-bot]

Size Analysis Report

Affected Products

No changes between base commit (a285f37) and head commit (c383ee1).

Test Logs

• Base (a285f37): https://github.com/firebase/firebase-js-sdk/actions/runs/855033573
• Head (c383ee1): https://github.com/firebase/firebase-js-sdk/actions/runs/857985543

[Feiyang1]

Please add a changeset

[schmidt-sebastian]

@Feiyang1 The size increase seems to be from the inclusion of AppCheck. Is that a good assumption?

[Feiyang1]

Do you want to use ^ version ?

[schmidt-sebastian]

Makes sense. I didn't realize we only use fixed versions for our own dependencies.

[Feiyang1]

I think so. the base is a commit before appcheck was merged into master. The diff should be much smaller if you rebase the PR.

[schmidt-sebastian]

Hm, I am not able to run the yarn update right now ("error An unexpected error occurred: "expected workspace package to exist for "inquirer"""). I will ping you once I updated the yarn.lock

[schmidt-sebastian]

@Feiyang1 CI finally passed. I had to update some random types after removing yarn.lock

[Feiyang1]

Is it required to pass CI? This is a wrong change because we are not using webpack@5. I will be okay with it if it's required to pass CI for some unknown reason. I don't want us to waste time on it and we should be updating to webpack@5 soon.

[schmidt-sebastian]

I am not sure if 5.x is required, but the version that was installed without the yarn.lock file caused compilation errors. I can try an older 4.x version, but we should be safe since the code itself did not change.

[schmidt-sebastian]

The problem is here (from the original yarn.lock):

"@types/webpack@4.41.25":
  version "4.41.25"
  resolved "https://registry.npmjs.org/@types/webpack/-/webpack-4.41.25.tgz#4d3b5aecc4e44117b376280fbfd2dc36697968c4"
  integrity sha512-cr6kZ+4m9lp86ytQc1jPOJXgINQyz3kLLunZ57jznW+WIAL0JqZbGubQk4GlD42MuQL5JGOABrxdpqqWeovlVQ==
  dependencies:
    "@types/anymatch" "*"
    "@types/node" "*"
    "@types/tapable" "*"
    "@types/uglify-js" "*"
    "@types/webpack-sources" "*"
    source-map "^0.6.0"

Webpack 4.x does not compile against tapable 2.x. The old version was 1.06 (before removing the lock file).

These are some of the errors:

../../node_modules/@types/webpack/index.d.ts:1106:32 - error TS2314: Generic type 'HookMap<H>' requires 1 type argument(s).

1106                 callAnyMember: HookMap;
                                    ~~~~~~~