Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support onInit callback to provider #4866

Merged
merged 10 commits into from
May 4, 2021
Merged

Support onInit callback to provider #4866

merged 10 commits into from
May 4, 2021

Conversation

Feiyang1
Copy link
Member

@Feiyang1 Feiyang1 commented May 4, 2021

onInit callbacks are invoked synchronously when Provider.initialize() executes. It allows a listener to react to provider initialization event synchronously to perform timing sensitive operations.

@changeset-bot
Copy link

changeset-bot bot commented May 4, 2021

🦋 Changeset detected

Latest commit: 1dbcffe

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 14 packages
Name Type
@firebase/component Minor
@firebase/analytics Patch
@firebase/app-check Patch
@firebase/app Patch
@firebase/database Patch
@firebase/firestore Patch
@firebase/functions Patch
@firebase/installations Patch
@firebase/messaging Patch
@firebase/performance Patch
@firebase/remote-config Patch
@firebase/rules-unit-testing Patch
@firebase/storage Patch
firebase Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2021

Changeset File Check ⚠️

  • Package @firebase/component has a minor bump which requires an additional line to bump the main "firebase" package to minor.

@google-oss-bot
Copy link
Contributor

Size Analysis Report

Affected Products

  • @firebase/app-exp

    • initializeApp

      Size Table

      TypeBase (d095ad3)Head (60f222f)Diff
      size-with-ext-deps
      10.8 kB
      11.0 kB
      +229 B (+2.1%)

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 4, 2021

Binary Size Report

Affected SDKs

  • @firebase/analytics

    Type Base (d095ad3) Head (45c2dd0) Diff
    esm2017 ? 18.7 kB ? (?)
    main ? 24.2 kB ? (?)
    module ? 23.4 kB ? (?)
  • @firebase/api-documenter

    Type Base (d095ad3) Head (45c2dd0) Diff
    main ? 3.72 kB ? (?)
  • @firebase/app

    Type Base (d095ad3) Head (45c2dd0) Diff
    browser ? 10.9 kB ? (?)
    esm2017 ? 9.63 kB ? (?)
    lite ? 8.95 kB ? (?)
    lite-esm2017 ? 7.93 kB ? (?)
    main ? 9.99 kB ? (?)
    module ? 10.9 kB ? (?)
    react-native ? 9.70 kB ? (?)
  • @firebase/auth

    Type Base (d095ad3) Head (45c2dd0) Diff
    browser ? 181 kB ? (?)
    main ? 181 kB ? (?)
    module ? 181 kB ? (?)
  • @firebase/component

    Type Base (d095ad3) Head (45c2dd0) Diff
    browser ? 7.84 kB ? (?)
    esm2017 ? 5.88 kB ? (?)
    main ? 8.18 kB ? (?)
    module ? 7.84 kB ? (?)
  • @firebase/database

    Type Base (d095ad3) Head (45c2dd0) Diff
    browser ? 296 kB ? (?)
    esm2017 ? 264 kB ? (?)
    main ? 298 kB ? (?)
    module ? 296 kB ? (?)
  • @firebase/database-compat

    Type Base (d095ad3) Head (45c2dd0) Diff
    browser ? 86.3 kB ? (?)
    main ? 102 kB ? (?)
    module ? 86.3 kB ? (?)
  • @firebase/database-exp

    Type Base (d095ad3) Head (45c2dd0) Diff
    browser ? 246 kB ? (?)
    main ? 278 kB ? (?)
    module ? 246 kB ? (?)
  • @firebase/firestore

    Type Base (d095ad3) Head (45c2dd0) Diff
    browser ? 283 kB ? (?)
    esm2017 ? 226 kB ? (?)
    main ? 530 kB ? (?)
    module ? 283 kB ? (?)
    react-native ? 226 kB ? (?)
  • @firebase/firestore-compat

    Type Base (d095ad3) Head (45c2dd0) Diff
    browser ? 28.6 kB ? (?)
    main ? 37.6 kB ? (?)
    module ? 28.6 kB ? (?)
    react-native ? 28.3 kB ? (?)
  • @firebase/firestore-exp

    Type Base (d095ad3) Head (45c2dd0) Diff
    browser ? 223 kB ? (?)
    main ? 506 kB ? (?)
    module ? 223 kB ? (?)
    react-native ? 224 kB ? (?)
  • @firebase/firestore-lite

    Type Base (d095ad3) Head (45c2dd0) Diff
    browser ? 72.0 kB ? (?)
    main ? 146 kB ? (?)
    module ? 72.0 kB ? (?)
    react-native ? 72.2 kB ? (?)
  • @firebase/firestore/bundle

    Type Base (d095ad3) Head (45c2dd0) Diff
    browser ? 289 kB ? (?)
    esm2017 ? 176 kB ? (?)
    main ? 526 kB ? (?)
    module ? 289 kB ? (?)
    react-native ? 176 kB ? (?)
  • @firebase/firestore/memory

    Type Base (d095ad3) Head (45c2dd0) Diff
    browser ? 215 kB ? (?)
    esm2017 ? 172 kB ? (?)
    main ? 324 kB ? (?)
    module ? 215 kB ? (?)
    react-native ? 172 kB ? (?)
  • @firebase/firestore/memory-bundle

    Type Base (d095ad3) Head (45c2dd0) Diff
    browser ? 224 kB ? (?)
    esm2017 ? 176 kB ? (?)
    main ? 321 kB ? (?)
    module ? 224 kB ? (?)
    react-native ? 176 kB ? (?)
  • @firebase/functions

    Type Base (d095ad3) Head (45c2dd0) Diff
    browser ? 10.6 kB ? (?)
    esm2017 ? 8.15 kB ? (?)
    main ? 11.0 kB ? (?)
    module ? 10.6 kB ? (?)
  • @firebase/installations

    Type Base (d095ad3) Head (45c2dd0) Diff
    esm2017 ? 16.6 kB ? (?)
    main ? 22.2 kB ? (?)
    module ? 21.6 kB ? (?)
  • @firebase/logger

    Type Base (d095ad3) Head (45c2dd0) Diff
    esm2017 ? 3.25 kB ? (?)
    main ? 5.38 kB ? (?)
    module ? 4.65 kB ? (?)
  • @firebase/messaging

    Type Base (d095ad3) Head (45c2dd0) Diff
    esm2017 ? 26.2 kB ? (?)
    main ? 34.9 kB ? (?)
    module ? 34.4 kB ? (?)
  • @firebase/performance

    Type Base (d095ad3) Head (45c2dd0) Diff
    browser ? 27.7 kB ? (?)
    esm2017 ? 25.9 kB ? (?)
    main ? 28.0 kB ? (?)
    module ? 27.7 kB ? (?)
  • @firebase/polyfill

    Type Base (d095ad3) Head (45c2dd0) Diff
    main ? 747 B ? (?)
    module ? 705 B ? (?)
  • @firebase/remote-config

    Type Base (d095ad3) Head (45c2dd0) Diff
    browser ? 22.4 kB ? (?)
    esm2017 ? 17.4 kB ? (?)
    main ? 23.0 kB ? (?)
    module ? 22.4 kB ? (?)
  • @firebase/rules-unit-testing

    Type Base (d095ad3) Head (45c2dd0) Diff
    main ? 12.6 kB ? (?)
  • @firebase/storage

    Type Base (d095ad3) Head (45c2dd0) Diff
    browser ? 63.4 kB ? (?)
    esm2017 ? 54.6 kB ? (?)
    main ? 63.8 kB ? (?)
    module ? 63.4 kB ? (?)
  • @firebase/storage-compat

    Type Base (d095ad3) Head (45c2dd0) Diff
    browser ? 10.2 kB ? (?)
    main ? 29.1 kB ? (?)
    module ? 10.2 kB ? (?)
  • @firebase/storage-exp

    Type Base (d095ad3) Head (45c2dd0) Diff
    browser ? 51.5 kB ? (?)
    main ? 52.6 kB ? (?)
    module ? 51.5 kB ? (?)
  • @firebase/util

    Type Base (d095ad3) Head (45c2dd0) Diff
    browser ? 21.2 kB ? (?)
    esm2017 ? 20.0 kB ? (?)
    main ? 25.8 kB ? (?)
    module ? 21.2 kB ? (?)
  • @firebase/webchannel-wrapper

    Type Base (d095ad3) Head (45c2dd0) Diff
    esm2017 ? 39.5 kB ? (?)
    main ? 46.9 kB ? (?)
    module ? 40.8 kB ? (?)
  • firebase

    Click to show 15 binary size changes.
    Type Base (d095ad3) Head (45c2dd0) Diff
    firebase-analytics.js ? 35.8 kB ? (?)
    firebase-app.js ? 21.7 kB ? (?)
    firebase-auth.js ? 177 kB ? (?)
    firebase-database.js ? 187 kB ? (?)
    firebase-firestore.js ? 332 kB ? (?)
    firebase-firestore.memory.js ? 266 kB ? (?)
    firebase-functions.js ? 10.7 kB ? (?)
    firebase-installations.js ? 19.3 kB ? (?)
    firebase-messaging.js ? 41.0 kB ? (?)
    firebase-performance-standalone.es2017.js ? 73.1 kB ? (?)
    firebase-performance-standalone.js ? 49.7 kB ? (?)
    firebase-performance.js ? 38.3 kB ? (?)
    firebase-remote-config.js ? 36.9 kB ? (?)
    firebase-storage.js ? 41.6 kB ? (?)
    firebase.js ? 875 kB ? (?)

Test Logs

@Feiyang1 Feiyang1 merged commit c34ac7a into master May 4, 2021
@Feiyang1 Feiyang1 deleted the fei-firestore-wait branch May 4, 2021 23:49
@google-oss-bot google-oss-bot mentioned this pull request May 4, 2021
@firebase firebase locked and limited conversation to collaborators Jun 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants