Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare to publish AppCheck package #4860

Merged
merged 6 commits into from
May 5, 2021
Merged

Prepare to publish AppCheck package #4860

merged 6 commits into from
May 5, 2021

Conversation

hsubox76
Copy link
Contributor

@hsubox76 hsubox76 commented May 4, 2021 •
edited

Prepare AppCheck to be published in the next release.

  • Make 3 packages public
    • app-check
    • app-check-types
    • app-check-interop-types
  • Add app-check import to
    • firebase/index.ts
    • firebase/index.cdn.ts
  • Add firebase/app-check folder with
    • package.json
    • index.ts
  • firebase/package.json
    • Add dependency
    • Add to components list
  • Add to toc.yaml (JS only)
  • Set up tokens for canary publish
  • Ensure local dependencies are up to date in app-check/package.json (redo after regular release tomorrow)

@changeset-bot
Copy link

changeset-bot bot commented May 4, 2021 •
edited

🦋 Changeset detected

Latest commit: 327e9ed

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@firebase/app-check Minor
@firebase/app-check-interop-types Minor
@firebase/app-check-types Minor
firebase Minor
@firebase/rules-unit-testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@hsubox76 hsubox76 changed the title Prepare to publish AppCheck package DO NOT MERGE until 5/4: Prepare to publish AppCheck package May 4, 2021
@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 4, 2021 •
edited

Size Analysis Report

Affected Products

Diffs between base commit (f3a1a3f) and head commit (15a2bf0) are too large (479,509 characters) to display.

Please check below links to see details from the original test log.

Feiyang1
Feiyang1 reviewed May 4, 2021
View reviewed changes
packages/app-check-interop-types/package.json Outdated Show resolved Hide resolved
packages/firebase/package.json Outdated Show resolved Hide resolved
@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

  • @firebase/analytics

    Type Base (f3a1a3f) Head (e9ed2ad) Diff
    esm2017 ? 18.7 kB ? (?)
    main ? 24.2 kB ? (?)
    module ? 23.4 kB ? (?)

  • @firebase/api-documenter

    Type Base (f3a1a3f) Head (e9ed2ad) Diff
    main ? 3.72 kB ? (?)

  • @firebase/app

    Type Base (f3a1a3f) Head (e9ed2ad) Diff
    browser ? 10.9 kB ? (?)
    esm2017 ? 9.63 kB ? (?)
    lite ? 8.95 kB ? (?)
    lite-esm2017 ? 7.93 kB ? (?)
    main ? 9.99 kB ? (?)
    module ? 10.9 kB ? (?)
    react-native ? 9.70 kB ? (?)

  • @firebase/app-check

    Type Base (f3a1a3f) Head (e9ed2ad) Diff
    browser ? 20.7 kB ? (?)
    esm2017 ? 17.1 kB ? (?)
    main ? 20.7 kB ? (?)
    module ? 20.2 kB ? (?)

  • @firebase/auth

    Type Base (f3a1a3f) Head (e9ed2ad) Diff
    browser ? 181 kB ? (?)
    main ? 181 kB ? (?)
    module ? 181 kB ? (?)

  • @firebase/component

    Type Base (f3a1a3f) Head (e9ed2ad) Diff
    browser ? 7.24 kB ? (?)
    esm2017 ? 5.55 kB ? (?)
    main ? 7.57 kB ? (?)
    module ? 7.24 kB ? (?)

  • @firebase/database

    Type Base (f3a1a3f) Head (e9ed2ad) Diff
    browser ? 296 kB ? (?)
    esm2017 ? 264 kB ? (?)
    main ? 298 kB ? (?)
    module ? 296 kB ? (?)

  • @firebase/database-compat

    Type Base (f3a1a3f) Head (e9ed2ad) Diff
    browser ? 86.3 kB ? (?)
    main ? 102 kB ? (?)
    module ? 86.3 kB ? (?)

  • @firebase/database-exp

    Type Base (f3a1a3f) Head (e9ed2ad) Diff
    browser ? 246 kB ? (?)
    main ? 278 kB ? (?)
    module ? 246 kB ? (?)

  • @firebase/firestore

    Type Base (f3a1a3f) Head (e9ed2ad) Diff
    browser ? 283 kB ? (?)
    esm2017 ? 226 kB ? (?)
    main ? 530 kB ? (?)
    module ? 283 kB ? (?)
    react-native ? 226 kB ? (?)

  • @firebase/firestore-compat

    Type Base (f3a1a3f) Head (e9ed2ad) Diff
    browser ? 28.6 kB ? (?)
    main ? 37.6 kB ? (?)
    module ? 28.6 kB ? (?)
    react-native ? 28.3 kB ? (?)

  • @firebase/firestore-exp

    Type Base (f3a1a3f) Head (e9ed2ad) Diff
    browser ? 223 kB ? (?)
    main ? 506 kB ? (?)
    module ? 223 kB ? (?)
    react-native ? 224 kB ? (?)

  • @firebase/firestore-lite

    Type Base (f3a1a3f) Head (e9ed2ad) Diff
    browser ? 72.0 kB ? (?)
    main ? 146 kB ? (?)
    module ? 72.0 kB ? (?)
    react-native ? 72.2 kB ? (?)

  • @firebase/firestore/bundle

    Type Base (f3a1a3f) Head (e9ed2ad) Diff
    browser ? 289 kB ? (?)
    esm2017 ? 176 kB ? (?)
    main ? 526 kB ? (?)
    module ? 289 kB ? (?)
    react-native ? 176 kB ? (?)

  • @firebase/firestore/memory

    Type Base (f3a1a3f) Head (e9ed2ad) Diff
    browser ? 215 kB ? (?)
    esm2017 ? 172 kB ? (?)
    main ? 324 kB ? (?)
    module ? 215 kB ? (?)
    react-native ? 172 kB ? (?)

  • @firebase/firestore/memory-bundle

    Type Base (f3a1a3f) Head (e9ed2ad) Diff
    browser ? 224 kB ? (?)
    esm2017 ? 176 kB ? (?)
    main ? 321 kB ? (?)
    module ? 224 kB ? (?)
    react-native ? 176 kB ? (?)

  • @firebase/functions

    Type Base (f3a1a3f) Head (e9ed2ad) Diff
    browser ? 10.6 kB ? (?)
    esm2017 ? 8.15 kB ? (?)
    main ? 11.0 kB ? (?)
    module ? 10.6 kB ? (?)

  • @firebase/installations

    Type Base (f3a1a3f) Head (e9ed2ad) Diff
    esm2017 ? 16.6 kB ? (?)
    main ? 22.2 kB ? (?)
    module ? 21.6 kB ? (?)

  • @firebase/logger

    Type Base (f3a1a3f) Head (e9ed2ad) Diff
    esm2017 ? 3.25 kB ? (?)
    main ? 5.38 kB ? (?)
    module ? 4.65 kB ? (?)

  • @firebase/messaging

    Type Base (f3a1a3f) Head (e9ed2ad) Diff
    esm2017 ? 26.2 kB ? (?)
    main ? 34.9 kB ? (?)
    module ? 34.4 kB ? (?)

  • @firebase/performance

    Type Base (f3a1a3f) Head (e9ed2ad) Diff
    browser ? 27.7 kB ? (?)
    esm2017 ? 25.9 kB ? (?)
    main ? 28.0 kB ? (?)
    module ? 27.7 kB ? (?)

  • @firebase/polyfill

    Type Base (f3a1a3f) Head (e9ed2ad) Diff
    main ? 747 B ? (?)
    module ? 705 B ? (?)

  • @firebase/remote-config

    Type Base (f3a1a3f) Head (e9ed2ad) Diff
    browser ? 22.4 kB ? (?)
    esm2017 ? 17.4 kB ? (?)
    main ? 23.0 kB ? (?)
    module ? 22.4 kB ? (?)

  • @firebase/rules-unit-testing

    Type Base (f3a1a3f) Head (e9ed2ad) Diff
    main ? 12.6 kB ? (?)

  • @firebase/storage

    Type Base (f3a1a3f) Head (e9ed2ad) Diff
    browser ? 63.4 kB ? (?)
    esm2017 ? 54.6 kB ? (?)
    main ? 63.8 kB ? (?)
    module ? 63.4 kB ? (?)

  • @firebase/storage-compat

    Type Base (f3a1a3f) Head (e9ed2ad) Diff
    browser ? 10.2 kB ? (?)
    main ? 29.1 kB ? (?)
    module ? 10.2 kB ? (?)

  • @firebase/storage-exp

    Type Base (f3a1a3f) Head (e9ed2ad) Diff
    browser ? 51.5 kB ? (?)
    main ? 52.6 kB ? (?)
    module ? 51.5 kB ? (?)

  • @firebase/util

    Type Base (f3a1a3f) Head (e9ed2ad) Diff
    browser ? 21.2 kB ? (?)
    esm2017 ? 20.0 kB ? (?)
    main ? 25.8 kB ? (?)
    module ? 21.2 kB ? (?)

  • @firebase/webchannel-wrapper

    Type Base (f3a1a3f) Head (e9ed2ad) Diff
    esm2017 ? 39.5 kB ? (?)
    main ? 46.9 kB ? (?)
    module ? 40.8 kB ? (?)

  • firebase

    Click to show 16 binary size changes.
    Type Base (f3a1a3f) Head (e9ed2ad) Diff
    firebase-analytics.js ? 35.8 kB ? (?)
    firebase-app-check.js ? 22.0 kB ? (?)
    firebase-app.js ? 21.2 kB ? (?)
    firebase-auth.js ? 177 kB ? (?)
    firebase-database.js ? 187 kB ? (?)
    firebase-firestore.js ? 332 kB ? (?)
    firebase-firestore.memory.js ? 266 kB ? (?)
    firebase-functions.js ? 10.7 kB ? (?)
    firebase-installations.js ? 19.3 kB ? (?)
    firebase-messaging.js ? 41.0 kB ? (?)
    firebase-performance-standalone.es2017.js ? 72.9 kB ? (?)
    firebase-performance-standalone.js ? 49.2 kB ? (?)
    firebase-performance.js ? 38.3 kB ? (?)
    firebase-remote-config.js ? 36.9 kB ? (?)
    firebase-storage.js ? 41.6 kB ? (?)
    firebase.js ? 887 kB ? (?)

Test Logs

@hsubox76 hsubox76 changed the title DO NOT MERGE until 5/4: Prepare to publish AppCheck package Prepare to publish AppCheck package May 5, 2021
@hsubox76 hsubox76 merged commit 81c131a into master May 5, 2021
@hsubox76 hsubox76 deleted the ch-appcheck-release branch May 5, 2021 22:58
@google-oss-bot google-oss-bot mentioned this pull request May 11, 2021
Merged
@firebase firebase locked and limited conversation to collaborators Jun 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Feiyang1 Feiyang1 Feiyang1 approved these changes

@hiranya911 hiranya911 Awaiting requested review from hiranya911

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hsubox76 @google-oss-bot @Feiyang1