Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a sanity check for useEmulator URL. #3934

Merged
merged 3 commits into from Oct 13, 2020
Merged

Add a sanity check for useEmulator URL. #3934

merged 3 commits into from Oct 13, 2020

Conversation

yuchenshi
Copy link
Member

Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:

Discussion

  • Read the contribution guidelines (CONTRIBUTING.md).
  • If this has been discussed in an issue, make sure to link to the issue here.
    If not, go file an issue about this before creating a pull request to discuss.

Testing

  • Make sure all existing tests in the repository pass after your change.
  • If you fixed a bug or added a feature, add a new test to cover your code.

API Changes

  • At this time we cannot accept changes that affect the public API. If you'd like to help
    us make Firebase APIs better, please propose your change in an issue so that we
    can discuss it together.

@changeset-bot
Copy link

changeset-bot bot commented Oct 13, 2020

🦋 Changeset detected

Latest commit: 309cedf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@firebase/auth Patch
firebase Patch
@firebase/rules-unit-testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

packages/auth/src/auth.js Outdated Show resolved Hide resolved
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 13, 2020

Binary Size Report

Affected SDKs

  • @firebase/auth

    Type Base (eeb1dfa) Head (17c9758) Diff
    browser 179 kB 179 kB +129 B (+0.1%)
    main 179 kB 179 kB +129 B (+0.1%)
    module 179 kB 179 kB +129 B (+0.1%)
  • firebase

    Type Base (eeb1dfa) Head (17c9758) Diff
    firebase-auth.js 176 kB 176 kB +129 B (+0.1%)
    firebase.js 831 kB 831 kB +129 B (+0.0%)

Test Logs

@Feiyang1 Feiyang1 merged commit 916770f into master Oct 13, 2020
@Feiyang1 Feiyang1 deleted the yuchenshi-patch-1 branch October 13, 2020 23:13
@google-oss-bot google-oss-bot mentioned this pull request Oct 13, 2020
@firebase firebase locked and limited conversation to collaborators Nov 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants