Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate rollup deprecated plugins to the new ones #3930

Merged
merged 5 commits into from Oct 13, 2020
Merged

Migrate rollup deprecated plugins to the new ones #3930

merged 5 commits into from Oct 13, 2020

Conversation

Feiyang1
Copy link
Member

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Oct 13, 2020 •
edited

⚠️ No Changeset found

Latest commit: 8a0782e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 13, 2020 •
edited

Binary Size Report

Affected SDKs

  • @firebase/app

    Type Base (d4966cf) Head (bd1da6c) Diff
    browser 11.1 kB 11.1 kB +2 B (+0.0%)
    esm2017 9.48 kB 9.48 kB +2 B (+0.0%)
    module 11.0 kB 11.0 kB +2 B (+0.0%)

  • @firebase/auth

    Type Base (d4966cf) Head (bd1da6c) Diff
    browser 177 kB 179 kB +1.92 kB (+1.1%)
    main 177 kB 179 kB +1.92 kB (+1.1%)
    module 177 kB 179 kB +1.92 kB (+1.1%)

  • @firebase/webchannel-wrapper

    Type Base (d4966cf) Head (bd1da6c) Diff
    esm2017 39.4 kB 39.3 kB -32 B (-0.1%)
    main 41.0 kB 46.7 kB +5.66 kB (+13.8%)
    module 40.6 kB 40.6 kB -32 B (-0.1%)

  • firebase

    Type Base (d4966cf) Head (bd1da6c) Diff
    firebase-app.js 20.1 kB 20.1 kB +2 B (+0.0%)
    firebase-auth.js 174 kB 176 kB +1.88 kB (+1.1%)
    firebase-firestore.js 287 kB 287 kB -173 B (-0.1%)
    firebase-firestore.memory.js 226 kB 226 kB -173 B (-0.1%)
    firebase.js 829 kB 831 kB +1.86 kB (+0.2%)

Test Logs

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 13, 2020 •
edited

Size Analysis Report

Affected Products

No changes between base commit (d4966cf) and head commit (bd1da6c).

Test Logs

@Feiyang1 Feiyang1 merged commit 00c963b into master Oct 13, 2020
@firebase firebase locked and limited conversation to collaborators Nov 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hsubox76 hsubox76 hsubox76 approved these changes

@alikn alikn Awaiting requested review from alikn

@andirayo andirayo Awaiting requested review from andirayo

@avolkovi avolkovi Awaiting requested review from avolkovi avolkovi is a code owner

@ChaoqunCHEN ChaoqunCHEN Awaiting requested review from ChaoqunCHEN

@davideast davideast Awaiting requested review from davideast

@erikeldridge erikeldridge Awaiting requested review from erikeldridge erikeldridge is a code owner

@hiranya911 hiranya911 Awaiting requested review from hiranya911

@jamesdaniels jamesdaniels Awaiting requested review from jamesdaniels

@jsdt jsdt Awaiting requested review from jsdt

@sam-gc sam-gc Awaiting requested review from sam-gc

@schmidt-sebastian schmidt-sebastian Awaiting requested review from schmidt-sebastian

@zijianjoy zijianjoy Awaiting requested review from zijianjoy

@zwu52 zwu52 Awaiting requested review from zwu52 zwu52 is a code owner

Assignees

@hsubox76 hsubox76

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Feiyang1 @google-oss-bot @hsubox76