Add a toJSON() function to auth-exp #3926

sam-gc · 2020-10-12T19:23:00Z

b/166287533

changeset-bot · 2020-10-12T19:23:03Z

⚠️ No Changeset found

Latest commit: eed0c8a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

google-oss-bot · 2020-10-12T19:39:21Z

Binary Size Report

Affected SDKs

No changes between base commit (cb28261) and head commit (f664938).

Test Logs

Base (cb28261e): https://github.com/firebase/firebase-js-sdk/actions/runs/302857547
Head (f664938c): https://github.com/firebase/firebase-js-sdk/actions/runs/302928157

google-oss-bot · 2020-10-12T19:42:15Z

Size Analysis Report

Affected Products

`@firebase/auth-exp`

ActionCodeURL

Size

Type Base (cb28261) Head (f664938) Diff

size 44.5 kB 44.7 kB +172 B (+0.4%)

size_with_ext_deps 55.1 kB 55.3 kB +172 B (+0.3%)
AuthCredential

Size

Type Base (cb28261) Head (f664938) Diff

size 43.8 kB 43.9 kB +172 B (+0.4%)

size_with_ext_deps 54.4 kB 54.6 kB +172 B (+0.3%)
EmailAuthCredential

Size

Type Base (cb28261) Head (f664938) Diff

size 45.5 kB 45.7 kB +172 B (+0.4%)

size_with_ext_deps 56.2 kB 56.4 kB +172 B (+0.3%)
EmailAuthProvider

Size

Type Base (cb28261) Head (f664938) Diff

size 46.9 kB 47.0 kB +172 B (+0.4%)

size_with_ext_deps 57.5 kB 57.7 kB +172 B (+0.3%)
FacebookAuthProvider

Size

Type Base (cb28261) Head (f664938) Diff

size 46.9 kB 47.1 kB +172 B (+0.4%)

size_with_ext_deps 57.6 kB 57.7 kB +172 B (+0.3%)
GithubAuthProvider

Size

Type Base (cb28261) Head (f664938) Diff

size 46.9 kB 47.1 kB +172 B (+0.4%)

size_with_ext_deps 57.5 kB 57.7 kB +172 B (+0.3%)
GoogleAuthProvider

Size

Type Base (cb28261) Head (f664938) Diff

size 46.9 kB 47.1 kB +172 B (+0.4%)

size_with_ext_deps 57.5 kB 57.7 kB +172 B (+0.3%)
OAuthCredential

Size

Type Base (cb28261) Head (f664938) Diff

size 45.6 kB 45.7 kB +172 B (+0.4%)

size_with_ext_deps 56.2 kB 56.4 kB +172 B (+0.3%)
OAuthProvider

Size

Type Base (cb28261) Head (f664938) Diff

size 46.3 kB 46.4 kB +172 B (+0.4%)

size_with_ext_deps 56.9 kB 57.1 kB +172 B (+0.3%)
PhoneAuthCredential

Size

Type Base (cb28261) Head (f664938) Diff

size 45.5 kB 45.7 kB +172 B (+0.4%)

size_with_ext_deps 56.2 kB 56.3 kB +172 B (+0.3%)
PhoneAuthProvider

Size

Type Base (cb28261) Head (f664938) Diff

size 47.2 kB 47.4 kB +172 B (+0.4%)

size_with_ext_deps 57.9 kB 58.1 kB +172 B (+0.3%)
PhoneMultiFactorGenerator

Size

Type Base (cb28261) Head (f664938) Diff

size 44.4 kB 44.6 kB +172 B (+0.4%)

size_with_ext_deps 55.1 kB 55.2 kB +172 B (+0.3%)
RecaptchaVerifier

Size

Type Base (cb28261) Head (f664938) Diff

size 50.0 kB 50.2 kB +172 B (+0.3%)

size_with_ext_deps 60.6 kB 60.8 kB +172 B (+0.3%)
TwitterAuthProvider

Size

Type Base (cb28261) Head (f664938) Diff

size 46.9 kB 47.1 kB +172 B (+0.4%)

size_with_ext_deps 57.6 kB 57.7 kB +172 B (+0.3%)
applyActionCode

Size

Type Base (cb28261) Head (f664938) Diff

size 43.6 kB 43.8 kB +172 B (+0.4%)

size_with_ext_deps 54.3 kB 54.4 kB +172 B (+0.3%)
browserLocalPersistence

Size

Type Base (cb28261) Head (f664938) Diff

size 46.4 kB 46.6 kB +172 B (+0.4%)

size_with_ext_deps 57.2 kB 57.3 kB +172 B (+0.3%)
browserPopupRedirectResolver

Size

Type Base (cb28261) Head (f664938) Diff

size 55.4 kB 55.6 kB +172 B (+0.3%)

size_with_ext_deps 66.2 kB 66.4 kB +172 B (+0.3%)
browserSessionPersistence

Size

Type Base (cb28261) Head (f664938) Diff

size 44.2 kB 44.3 kB +172 B (+0.4%)

size_with_ext_deps 54.8 kB 55.0 kB +172 B (+0.3%)
checkActionCode

Size

Type Base (cb28261) Head (f664938) Diff

size 44.6 kB 44.8 kB +172 B (+0.4%)

size_with_ext_deps 55.3 kB 55.5 kB +172 B (+0.3%)
confirmPasswordReset

Size

Type Base (cb28261) Head (f664938) Diff

size 43.6 kB 43.8 kB +172 B (+0.4%)

size_with_ext_deps 54.3 kB 54.5 kB +172 B (+0.3%)
createUserWithEmailAndPassword

Size

Type Base (cb28261) Head (f664938) Diff

size 44.5 kB 44.7 kB +172 B (+0.4%)

size_with_ext_deps 55.2 kB 55.4 kB +172 B (+0.3%)
deleteUser

Size

Type Base (cb28261) Head (f664938) Diff

size 43.5 kB 43.7 kB +172 B (+0.4%)

size_with_ext_deps 54.2 kB 54.4 kB +172 B (+0.3%)
fetchSignInMethodsForEmail

Size

Type Base (cb28261) Head (f664938) Diff

size 43.8 kB 44.0 kB +172 B (+0.4%)

size_with_ext_deps 54.5 kB 54.7 kB +172 B (+0.3%)
getAdditionalUserInfo

Size

Type Base (cb28261) Head (f664938) Diff

size 44.8 kB 44.9 kB +172 B (+0.4%)

size_with_ext_deps 55.4 kB 55.6 kB +172 B (+0.3%)
getAuth

Size

Type Base (cb28261) Head (f664938) Diff

size 61.2 kB 61.4 kB +172 B (+0.3%)

size_with_ext_deps 72.7 kB 72.9 kB +172 B (+0.2%)
getIdToken

Size

Type Base (cb28261) Head (f664938) Diff

size 43.5 kB 43.7 kB +172 B (+0.4%)

size_with_ext_deps 54.2 kB 54.4 kB +172 B (+0.3%)
getIdTokenResult

Size

Type Base (cb28261) Head (f664938) Diff

size 43.5 kB 43.7 kB +172 B (+0.4%)

size_with_ext_deps 54.2 kB 54.3 kB +172 B (+0.3%)
getMultiFactorResolver

Size

Type Base (cb28261) Head (f664938) Diff

size 46.4 kB 46.6 kB +172 B (+0.4%)

size_with_ext_deps 57.1 kB 57.2 kB +172 B (+0.3%)
getRedirectResult

Size

Type Base (cb28261) Head (f664938) Diff

size 49.0 kB 49.1 kB +172 B (+0.4%)

size_with_ext_deps 59.6 kB 59.8 kB +172 B (+0.3%)
inMemoryPersistence

Size

Type Base (cb28261) Head (f664938) Diff

size 43.5 kB 43.7 kB +172 B (+0.4%)

size_with_ext_deps 54.2 kB 54.3 kB +172 B (+0.3%)
indexedDBLocalPersistence

Size

Type Base (cb28261) Head (f664938) Diff

size 46.6 kB 46.8 kB +172 B (+0.4%)

size_with_ext_deps 57.2 kB 57.4 kB +172 B (+0.3%)
initializeAuth

Size

Type Base (cb28261) Head (f664938) Diff

size 43.8 kB 44.0 kB +172 B (+0.4%)

size_with_ext_deps 55.1 kB 55.3 kB +172 B (+0.3%)
isSignInWithEmailLink

Size

Type Base (cb28261) Head (f664938) Diff

size 44.6 kB 44.8 kB +172 B (+0.4%)

size_with_ext_deps 55.3 kB 55.4 kB +172 B (+0.3%)
linkWithCredential

Size

Type Base (cb28261) Head (f664938) Diff

size 44.6 kB 44.7 kB +172 B (+0.4%)

size_with_ext_deps 55.2 kB 55.4 kB +172 B (+0.3%)
linkWithPhoneNumber

Size

Type Base (cb28261) Head (f664938) Diff

size 48.1 kB 48.2 kB +172 B (+0.4%)

size_with_ext_deps 58.7 kB 58.9 kB +172 B (+0.3%)
linkWithPopup

Size

Type Base (cb28261) Head (f664938) Diff

size 52.0 kB 52.2 kB +172 B (+0.3%)

size_with_ext_deps 62.7 kB 62.9 kB +172 B (+0.3%)
linkWithRedirect

Size

Type Base (cb28261) Head (f664938) Diff

size 47.1 kB 47.2 kB +172 B (+0.4%)

size_with_ext_deps 57.7 kB 57.9 kB +172 B (+0.3%)
multiFactor

Size

Type Base (cb28261) Head (f664938) Diff

size 45.6 kB 45.8 kB +172 B (+0.4%)

size_with_ext_deps 56.3 kB 56.4 kB +172 B (+0.3%)
onAuthStateChanged

Size

Type Base (cb28261) Head (f664938) Diff

size 43.6 kB 43.7 kB +172 B (+0.4%)

size_with_ext_deps 54.2 kB 54.4 kB +172 B (+0.3%)
onIdTokenChanged

Size

Type Base (cb28261) Head (f664938) Diff

size 43.6 kB 43.7 kB +172 B (+0.4%)

size_with_ext_deps 54.2 kB 54.4 kB +172 B (+0.3%)
parseActionCodeURL

Size

Type Base (cb28261) Head (f664938) Diff

size 44.5 kB 44.7 kB +172 B (+0.4%)

size_with_ext_deps 55.2 kB 55.4 kB +172 B (+0.3%)
reauthenticateWithCredential

Size

Type Base (cb28261) Head (f664938) Diff

size 45.2 kB 45.3 kB +172 B (+0.4%)

size_with_ext_deps 55.8 kB 56.0 kB +172 B (+0.3%)
reauthenticateWithPhoneNumber

Size

Type Base (cb28261) Head (f664938) Diff

size 48.6 kB 48.8 kB +172 B (+0.4%)

size_with_ext_deps 59.3 kB 59.5 kB +172 B (+0.3%)
reauthenticateWithPopup

Size

Type Base (cb28261) Head (f664938) Diff

size 52.0 kB 52.2 kB +172 B (+0.3%)

size_with_ext_deps 62.7 kB 62.9 kB +172 B (+0.3%)
reauthenticateWithRedirect

Size

Type Base (cb28261) Head (f664938) Diff

size 46.8 kB 47.0 kB +172 B (+0.4%)

size_with_ext_deps 57.5 kB 57.6 kB +172 B (+0.3%)
reload

Size

Type Base (cb28261) Head (f664938) Diff

size 43.5 kB 43.7 kB +172 B (+0.4%)

size_with_ext_deps 54.1 kB 54.3 kB +172 B (+0.3%)
sendEmailVerification

Size

Type Base (cb28261) Head (f664938) Diff

size 44.1 kB 44.3 kB +172 B (+0.4%)

size_with_ext_deps 54.8 kB 54.9 kB +172 B (+0.3%)
sendPasswordResetEmail

Size

Type Base (cb28261) Head (f664938) Diff

size 44.0 kB 44.2 kB +172 B (+0.4%)

size_with_ext_deps 54.7 kB 54.8 kB +172 B (+0.3%)
sendSignInLinkToEmail

Size

Type Base (cb28261) Head (f664938) Diff

size 44.0 kB 44.2 kB +172 B (+0.4%)

size_with_ext_deps 54.7 kB 54.8 kB +172 B (+0.3%)
setPersistence

Size

Type Base (cb28261) Head (f664938) Diff

size 43.5 kB 43.7 kB +172 B (+0.4%)

size_with_ext_deps 54.2 kB 54.4 kB +172 B (+0.3%)
signInAnonymously

Size

Type Base (cb28261) Head (f664938) Diff

size 44.6 kB 44.8 kB +172 B (+0.4%)

size_with_ext_deps 55.3 kB 55.5 kB +172 B (+0.3%)
signInWithCredential

Size

Type Base (cb28261) Head (f664938) Diff

size 44.9 kB 45.1 kB +172 B (+0.4%)

size_with_ext_deps 55.5 kB 55.7 kB +172 B (+0.3%)
signInWithCustomToken

Size

Type Base (cb28261) Head (f664938) Diff

size 44.5 kB 44.7 kB +172 B (+0.4%)

size_with_ext_deps 55.2 kB 55.3 kB +172 B (+0.3%)
signInWithEmailAndPassword

Size

Type Base (cb28261) Head (f664938) Diff

size 48.3 kB 48.5 kB +172 B (+0.4%)

size_with_ext_deps 59.0 kB 59.1 kB +172 B (+0.3%)
signInWithEmailLink

Size

Type Base (cb28261) Head (f664938) Diff

size 48.5 kB 48.7 kB +172 B (+0.4%)

size_with_ext_deps 59.2 kB 59.4 kB +172 B (+0.3%)
signInWithPhoneNumber

Size

Type Base (cb28261) Head (f664938) Diff

size 48.3 kB 48.5 kB +172 B (+0.4%)

size_with_ext_deps 59.0 kB 59.2 kB +172 B (+0.3%)
signInWithPopup

Size

Type Base (cb28261) Head (f664938) Diff

size 52.0 kB 52.2 kB +172 B (+0.3%)

size_with_ext_deps 62.7 kB 62.9 kB +172 B (+0.3%)
signInWithRedirect

Size

Type Base (cb28261) Head (f664938) Diff

size 46.5 kB 46.7 kB +172 B (+0.4%)

size_with_ext_deps 57.2 kB 57.4 kB +172 B (+0.3%)
signOut

Size

Type Base (cb28261) Head (f664938) Diff

size 43.5 kB 43.7 kB +172 B (+0.4%)

size_with_ext_deps 54.2 kB 54.4 kB +172 B (+0.3%)
unlink

Size

Type Base (cb28261) Head (f664938) Diff

size 44.1 kB 44.3 kB +172 B (+0.4%)

size_with_ext_deps 54.8 kB 54.9 kB +172 B (+0.3%)
updateCurrentUser

Size

Type Base (cb28261) Head (f664938) Diff

size 43.6 kB 43.7 kB +172 B (+0.4%)

size_with_ext_deps 54.2 kB 54.4 kB +172 B (+0.3%)
updateEmail

Size

Type Base (cb28261) Head (f664938) Diff

size 43.8 kB 44.0 kB +172 B (+0.4%)

size_with_ext_deps 54.5 kB 54.6 kB +172 B (+0.3%)
updatePassword

Size

Type Base (cb28261) Head (f664938) Diff

size 43.8 kB 44.0 kB +172 B (+0.4%)

size_with_ext_deps 54.5 kB 54.6 kB +172 B (+0.3%)
updatePhoneNumber

Size

Type Base (cb28261) Head (f664938) Diff

size 44.3 kB 44.4 kB +172 B (+0.4%)

size_with_ext_deps 54.9 kB 55.1 kB +172 B (+0.3%)
updateProfile

Size

Type Base (cb28261) Head (f664938) Diff

size 44.0 kB 44.2 kB +172 B (+0.4%)

size_with_ext_deps 54.6 kB 54.8 kB +172 B (+0.3%)
useDeviceLanguage

Size

Type Base (cb28261) Head (f664938) Diff

size 43.5 kB 43.7 kB +172 B (+0.4%)

size_with_ext_deps 54.2 kB 54.4 kB +172 B (+0.3%)
verifyBeforeUpdateEmail

Size

Type Base (cb28261) Head (f664938) Diff

size 44.1 kB 44.3 kB +172 B (+0.4%)

size_with_ext_deps 54.8 kB 55.0 kB +172 B (+0.3%)
verifyPasswordResetCode

Size

Type Base (cb28261) Head (f664938) Diff

size 44.7 kB 44.9 kB +172 B (+0.4%)

size_with_ext_deps 55.4 kB 55.5 kB +172 B (+0.3%)

Test Logs

Base (cb28261e): https://github.com/firebase/firebase-js-sdk/actions/runs/302857547
Head (f664938c): https://github.com/firebase/firebase-js-sdk/actions/runs/302928157

sam-gc requested a review from avolkovi October 12, 2020 19:23

sam-gc assigned avolkovi Oct 12, 2020

avolkovi approved these changes Oct 12, 2020

View reviewed changes

avolkovi assigned sam-gc and unassigned avolkovi Oct 12, 2020

sam-gc added 3 commits October 12, 2020 13:49

Add toJSON to auth-exp

075778a

Splitting

1d89482

Formatting

eed0c8a

sam-gc force-pushed the samgho/auth-json branch from 2cd496f to eed0c8a Compare October 12, 2020 20:49

sam-gc merged commit 3c420b0 into master Oct 12, 2020

sam-gc deleted the samgho/auth-json branch October 12, 2020 21:33

firebase locked and limited conversation to collaborators Nov 12, 2020

Add a toJSON() function to auth-exp #3926

Add a toJSON() function to auth-exp #3926

Conversation

sam-gc commented Oct 12, 2020

changeset-bot bot commented Oct 12, 2020 • edited

⚠️ No Changeset found

google-oss-bot commented Oct 12, 2020 • edited

Binary Size Report

Affected SDKs

Test Logs

google-oss-bot commented Oct 12, 2020 • edited

Size Analysis Report

Affected Products

@firebase/auth-exp

ActionCodeURL

Size

AuthCredential

Size

EmailAuthCredential

Size

EmailAuthProvider

Size

FacebookAuthProvider

Size

GithubAuthProvider

Size

GoogleAuthProvider

Size

OAuthCredential

Size

OAuthProvider

Size

PhoneAuthCredential

Size

PhoneAuthProvider

Size

PhoneMultiFactorGenerator

Size

RecaptchaVerifier

Size

TwitterAuthProvider

Size

applyActionCode

Size

browserLocalPersistence

Size

browserPopupRedirectResolver

Size

browserSessionPersistence

Size

checkActionCode

Size

confirmPasswordReset

Size

createUserWithEmailAndPassword

Size

deleteUser

Size

fetchSignInMethodsForEmail

Size

getAdditionalUserInfo

Size

getAuth

Size

getIdToken

Size

getIdTokenResult

Size

getMultiFactorResolver

Size

getRedirectResult

Size

inMemoryPersistence

Size

indexedDBLocalPersistence

Size

initializeAuth

Size

isSignInWithEmailLink

Size

changeset-bot bot commented Oct 12, 2020 •

edited

google-oss-bot commented Oct 12, 2020 •

edited

google-oss-bot commented Oct 12, 2020 •

edited

`@firebase/auth-exp`

`ActionCodeURL`

`AuthCredential`

`EmailAuthCredential`

`EmailAuthProvider`

`FacebookAuthProvider`

`GithubAuthProvider`

`GoogleAuthProvider`

`OAuthCredential`

`OAuthProvider`

`PhoneAuthCredential`

`PhoneAuthProvider`

`PhoneMultiFactorGenerator`

`RecaptchaVerifier`

`TwitterAuthProvider`

`applyActionCode`

`browserLocalPersistence`

`browserPopupRedirectResolver`

`browserSessionPersistence`

`checkActionCode`

`confirmPasswordReset`

`createUserWithEmailAndPassword`

`deleteUser`

`fetchSignInMethodsForEmail`

`getAdditionalUserInfo`

`getAuth`

`getIdToken`

`getIdTokenResult`

`getMultiFactorResolver`

`getRedirectResult`

`inMemoryPersistence`

`indexedDBLocalPersistence`

`initializeAuth`

`isSignInWithEmailLink`

`linkWithCredential`

`linkWithPhoneNumber`

`linkWithPopup`

`linkWithRedirect`

`multiFactor`

`onAuthStateChanged`

`onIdTokenChanged`

`parseActionCodeURL`

`reauthenticateWithCredential`

`reauthenticateWithPhoneNumber`

`reauthenticateWithPopup`

`reauthenticateWithRedirect`

`reload`

`sendEmailVerification`

`sendPasswordResetEmail`

`sendSignInLinkToEmail`

`setPersistence`

`signInAnonymously`

`signInWithCredential`

`signInWithCustomToken`

`signInWithEmailAndPassword`

`signInWithEmailLink`

`signInWithPhoneNumber`

`signInWithPopup`

`signInWithRedirect`

`signOut`

`unlink`

`updateCurrentUser`

`updateEmail`

`updatePassword`

`updatePhoneNumber`

`updateProfile`

`useDeviceLanguage`