Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a way to specify emulator host/port for Auth #3810

Merged
merged 11 commits into from Oct 13, 2020
Merged

Add a way to specify emulator host/port for Auth #3810

merged 11 commits into from Oct 13, 2020

Conversation

avolkovi
Copy link
Contributor

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Sep 18, 2020 •
edited

🦋 Changeset detected

Latest commit: f6f3d70

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@firebase/auth Minor
firebase Minor
@firebase/rules-unit-testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 18, 2020 •
edited

Binary Size Report

Affected SDKs

  • @firebase/auth

    Type Base (d4966cf) Head (c0b6026) Diff
    browser 177 kB 179 kB +1.92 kB (+1.1%)
    main 177 kB 179 kB +1.92 kB (+1.1%)
    module 177 kB 179 kB +1.92 kB (+1.1%)

  • firebase

    Type Base (d4966cf) Head (c0b6026) Diff
    firebase-auth.js 174 kB 176 kB +1.88 kB (+1.1%)
    firebase.js 829 kB 831 kB +1.88 kB (+0.2%)

Test Logs

@avolkovi avolkovi marked this pull request as ready for review September 21, 2020 23:17
MeghaB
MeghaB approved these changes Sep 21, 2020
View reviewed changes
Copy link
Contributor

@MeghaB MeghaB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - thanks for adding the console warning!

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 1, 2020 •
edited

Size Analysis Report

Affected Products

No changes between base commit (d4966cf) and head commit (f0e3aa1).

Test Logs

sam-gc
sam-gc reviewed Oct 13, 2020
View reviewed changes
packages/auth/src/auth.js Outdated Show resolved Hide resolved
Feiyang1
Feiyang1 suggested changes Oct 13, 2020
View reviewed changes
Copy link
Member

@Feiyang1 Feiyang1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add the corresponding typings to packages/firebase/index.d.ts?

@Feiyang1
Copy link
Member

Feiyang1 commented Oct 13, 2020 •
edited

Actually are you planning to make this API public now, or later?
If you are making it public now, you need to add typings and a changeset, otherwise it is good to go.

@avolkovi avolkovi force-pushed the avolkovi/auth-emulator branch 3 times, most recently from 6193868 to 3f56454 Compare October 13, 2020 20:52
@avolkovi avolkovi assigned Feiyang1 and unassigned MeghaB and sam-gc Oct 13, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Oct 13, 2020 •
edited

Changeset File Check ✅

No modified packages are missing from the changeset file.

avolkovi and others added 2 commits October 13, 2020 14:07
@avolkovi @Feiyang1
Update packages/firebase/index.d.ts
704b80e 
Co-authored-by: Feiyang <feiyangc@google.com>
@avolkovi @Feiyang1
Update .changeset/clean-toes-pump.md
f6f3d70 
Co-authored-by: Feiyang <feiyangc@google.com>
@avolkovi avolkovi merged commit eeb1dfa into master Oct 13, 2020
@avolkovi avolkovi deleted the avolkovi/auth-emulator branch October 13, 2020 21:30
@google-oss-bot google-oss-bot mentioned this pull request Oct 13, 2020
Merged
@firebase firebase locked and limited conversation to collaborators Nov 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yuchenshi yuchenshi yuchenshi left review comments

@MeghaB MeghaB MeghaB approved these changes

@sam-gc sam-gc sam-gc approved these changes

@Feiyang1 Feiyang1 Feiyang1 approved these changes

@bojeil-google bojeil-google Awaiting requested review from bojeil-google

@scottcrossen scottcrossen Awaiting requested review from scottcrossen

Assignees

@Feiyang1 Feiyang1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@avolkovi @google-oss-bot @Feiyang1 @MeghaB @sam-gc @yuchenshi