Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CORS on V2 Functions #1355

Open
oudmane opened this issue Mar 3, 2023 · 2 comments
Open

CORS on V2 Functions #1355

oudmane opened this issue Mar 3, 2023 · 2 comments
Labels
api: http type: feature request

Comments

@oudmane
Copy link

oudmane commented Mar 3, 2023

In v2, cors param on https.onCall should accept cors.CorsOptions object like on v1, the frontend app keeps sending check for CORS (OPTIONS) before every request because there isn't no maxAge set.
I can make a pull request for this, let me know what you think.
@google-oss-bot
Copy link
Collaborator

I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.

@MNITD
Copy link

MNITD commented Feb 1, 2024

+1 for the feature for the same reason mentioned in the issue:

the frontend app keeps sending check for CORS (OPTIONS) before every request because there isn't no maxAge set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api: http type: feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@oudmane @taeold @MNITD @google-oss-bot