Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Max number of instances. #1323

Open
deepak786 opened this issue Dec 6, 2022 · 5 comments
Open

Max number of instances. #1323

deepak786 opened this issue Dec 6, 2022 · 5 comments
Labels
infrastructure Infrastructure issues reproducible: yes Issue with a repro type: bug

Comments

@deepak786
Copy link

Deployed the v1 event-driven cloud function with the following configuration:

"dependencies": {
    "firebase-admin": "^11.3.0",
    "firebase-functions": "^4.1.0"
},
"engines": {
    "node": "16"
}

The function is without runWith configuration.
After deploying, the firebase console automatically shows the max instance limit of 3000.

Screen Shot 2022-12-06 at 3 23 18 PM

Is 3000, the default max limit?

@google-oss-bot
Copy link
Collaborator

I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.

@larssn
Copy link

larssn commented Dec 7, 2022

EDIT
Turns out I was stuck on an old version of firebase-tools, due to having multiple Node installations (NVM).
After fixing the problem, my error went away.

ORIGINAL POST

Getting a probably related error:

Error: Failed to parse build specification:
- FirebaseError Expected endpoints[createNewBillingMonth].minInstances to be a number; was object

This happens when deploying using firebase deploy --only functions.

This is in a function that has a runWith that looks like this:

export const createNewBillingMonth = region('europe-west1')
  .runWith({
    timeoutSeconds: 540,
    memory: '1GB',
  })

If I fill out minInstances, it starts complaining about maxInstances

@deepak786
Copy link
Author

@taeold Can you please look into it?

@redsky500
Copy link

@taeold

EDIT Turns out I was stuck on an old version of firebase-tools, due to having multiple Node installations (NVM). After fixing the problem, my error went away.

ORIGINAL POST

Getting a probably related error:

Error: Failed to parse build specification:
- FirebaseError Expected endpoints[createNewBillingMonth].minInstances to be a number; was object

This happens when deploying using firebase deploy --only functions.

This is in a function that has a runWith that looks like this:

export const createNewBillingMonth = region('europe-west1')
  .runWith({
    timeoutSeconds: 540,
    memory: '1GB',
  })

If I fill out minInstances, it starts complaining about maxInstances

Can you explain in more detail?
I upgraded firebase version to latest but still getting same issue.

@exaby73
Copy link

exaby73 commented Nov 10, 2023

Picking up this for investigation, the endpoint that generates the YAML contract that configures the function on GCP/Firebase sets the maxInstaces to null. According to the contract as far as I know, the default maxInstances is supposed to be 1000

@exaby73 exaby73 added type: bug infrastructure Infrastructure issues reproducible: yes Issue with a repro and removed needs-triage labels Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Infrastructure issues reproducible: yes Issue with a repro type: bug
Projects
None yet
Development

No branches or pull requests

5 participants