Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes a bug that disallowed setting customClaims and/or sessionClaims in blocking functions #1199

Merged
merged 2 commits into from Aug 23, 2022
Merged

Fixes a bug that disallowed setting customClaims and/or sessionClaims in blocking functions #1199

merged 2 commits into from Aug 23, 2022

Conversation

colerogers
Copy link
Contributor

  • Adds customClaims and sessionClaims to the updateMask.

@colerogers colerogers changed the title Fixes customClaims and sessionClaims behavior in blocking functions Fixes a bug that disallowed setting customClaims and/or sessionClaims in blocking functions Aug 23, 2022
taeold
taeold approved these changes Aug 23, 2022
View reviewed changes
Copy link
Contributor

@taeold taeold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It sounds like pulling customClaims and sessionClaims out was intentional at some point - what changed?

@colerogers
Copy link
Contributor Author

@taeold Originally, we had the update mask function recurse into keys and stopped if we hit custom or session claims. We changed behavior & rewrote the code, but never removed the the if check and tests 🤦‍♂️

@colerogers colerogers merged commit f9ecee4 into master Aug 23, 2022
This was referenced Aug 24, 2022
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taeold taeold taeold approved these changes

@TheIronDev TheIronDev Awaiting requested review from TheIronDev

@inlined inlined Awaiting requested review from inlined

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@colerogers @taeold