Update CloudEvent types #1089
Merged
Update CloudEvent types #1089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes several updates to the exported CloudEvent types. * Billing types include a notificationType * [Link](https://github.com/googleapis/google-cloudevents/blob/main/proto/google/events/firebase/firebasealerts/v1/cloud_event_payload.proto#L132-L133) * Crashlytics have more documentation on fields * Storage has an exported `StorageEvent` which includes the bucket. * Storage function api references `StorageEvent` to better match to expected output.
Updated more signatures to optionally expect a bucket.
TheIronDev
commented
Apr 30, 2022
| @@ -382,7 +389,7 @@ export function getOptsAndBucket( | |||
| bucket = bucketOrOpts; | |||
| opts = {}; | |||
| } else { | |||
| bucket = bucketOrOpts.bucket || firebaseConfig().storageBucket; | |||
| bucket = bucketOrOpts.bucket || firebaseConfig()?.storageBucket; | |||
There was a problem hiding this comment.
This was the NPE culprit. firebaseConfig() is nullable, so attempting to access storageBucket throw an exception.
colerogers
approved these changes
May 2, 2022
| principalEmail: string; | ||
| /** The type of the notification, e.g. upgrade, downgrade */ | ||
| notificationType: string; |
There was a problem hiding this comment.
oh nice catch, I think I missed this field and meant to add it a while ago 🤦♂️
| bucket: string; | ||
| } | ||
|
|
||
| export type StorageEvent = CloudEvent<StorageObjectData, WithBucket>; |
There was a problem hiding this comment.
Oh interesting, I didn't realize that storage also uses custom extension attributes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to exported CloudEvent Types
This commit makes several updates to the exported CloudEvent types.
storageBucketfrom a null firebase configStorageEventwhich includes the bucket.StorageEventto better match to expected output.Description
Code sample