Add auth blocking handlers #1080

colerogers · 2022-04-18T00:55:55Z

Still a WIP until Admin SDK changes are released, the build will FAIL until then.

Adds v1 & v2 handlers for auth blocking triggers
Adds blockingTrigger to Trigger & Endpoint annotations
Adds reference to Admin SDK blocking token verification
Yanks custom rolled token verification & decoding
Adds Unit tests

package.json

src/common/providers/identity.ts

src/v2/providers/identity.ts

spec/v1/providers/auth.spec.ts

spec/v2/providers/identity.spec.ts

tsconfig.release.json

taeold

lgtm - can you bring up skipLibCheck in maybe Firebase CLI chatroom to see if this is "dangerous"

inlined

Escalating the dom vs skipLibCheck concern. Hang tight.

src/providers/auth.ts

src/v2/providers/identity.ts

* Add polyfill to avoid depending on DOM or using skipLibCheck * Formatter * Linter

colerogers added 12 commits March 31, 2022 16:46

adding inital components for v1

343bc3c

getting the sdk to work with the cli

9b4557b

merging master

9adba4d

more tinkering

7e3d945

reverting package-lock

71adb83

cleaning up things

f1c1941

adding back old package-lock

cb6cf79

merge master

af8cb43

adding current package & check before using admin api

5c5175a

merging

aef3705

cleaning up & starting tests

bbb2b30

removing old token verification peices & adding tests for v1/v2 handlers

b7877ca

colerogers requested review from inlined and taeold April 18, 2022 22:18

colerogers added the DO NOT MERGE label Apr 19, 2022

colerogers added 5 commits April 20, 2022 11:25

remove node-fetch

0cf8373

bumping admin version & removing node-fetch types

fbd05be

add back in the @types

0507452

add RS256 alg to broken test

3d1807b

adding DOM to fix tsc errors

5d31e51

colerogers marked this pull request as ready for review April 22, 2022 21:29

colerogers removed the DO NOT MERGE label Apr 22, 2022

adding skip lib check

179f52f

taeold reviewed Apr 25, 2022

View reviewed changes

address comments

5799d27

colerogers requested a review from taeold April 25, 2022 22:06

exporting HttpsError from v1 & v2 namespaces

301788a

taeold approved these changes Apr 27, 2022

View reviewed changes

inlined reviewed Apr 28, 2022

View reviewed changes

src/providers/auth.ts Outdated Show resolved Hide resolved

src/v2/providers/identity.ts Outdated Show resolved Hide resolved

wrap the handlers, remove skipLibCheck, and add back in node-fetch

15442cf

Add polyfill to avoid depending on DOM or using skipLibCheck (#1085)

4d4d009

* Add polyfill to avoid depending on DOM or using skipLibCheck * Formatter * Linter

colerogers merged commit 143eea8 into master Apr 28, 2022

colerogers deleted the colerogers.add-auth-blocking-triggers branch April 28, 2022 21:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add auth blocking handlers #1080

Add auth blocking handlers #1080

colerogers commented Apr 18, 2022 •

edited

taeold left a comment

inlined left a comment

Add auth blocking handlers #1080

Add auth blocking handlers #1080

Conversation

colerogers commented Apr 18, 2022 • edited

taeold left a comment

Choose a reason for hiding this comment

inlined left a comment

Choose a reason for hiding this comment

colerogers commented Apr 18, 2022 •

edited