Add CPU option. Rip out deprecated apiVersion #1077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taeold
approved these changes
Apr 15, 2022
| import * as admin from 'firebase-admin'; | ||
| import fetch from 'node-fetch'; |
There was a problem hiding this comment.
q: do you have some eslint locally that automatically formats this? (or is it something you did manually)
There was a problem hiding this comment.
npm run format:fix && npm run lint:fix
src/runtime/loader.ts
Outdated
| if ( | ||
| typeof val === 'function' && | ||
| val['__endpoint'] && | ||
| typeof val['__endpoint'] === 'object' | ||
| (val as any).__endpoint && |
There was a problem hiding this comment.
nit* is (val as any) required here? I'd guess it's already any based on L69.
There was a problem hiding this comment.
You're right. I was doing this manually and then used the any cast above. Will remove.
src/v2/options.ts
Outdated
|
|
||
| /** | ||
| * Fractional number of CPUs to allocate to a function. | ||
| * defaults to 1 for functions with <= 2GB RAM and increases for larger memory sizes. |
There was a problem hiding this comment.
Suggested change
| * defaults to 1 for functions with <= 2GB RAM and increases for larger memory sizes. | |
| * Defaults to 1 for functions with <= 2GB RAM and increases for larger memory sizes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes a couple of build errors I was getting in identity.ts