Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for more instance sizes and regions #1037

Merged
merged 3 commits into from Feb 23, 2022

Conversation

inlined
Copy link
Member

@inlined inlined commented Feb 10, 2022

Alphabetized and expanded the list of supported regions. Add support for high and low memory function sizes that are now supported.

@inlined inlined requested a review from taeold February 10, 2022 01:51
@inlined inlined merged commit 2b83e1d into master Feb 23, 2022
taeold added a commit that referenced this pull request Mar 7, 2022
…ers (#1052)

Previously, `eventFilter` attribute was an object:

```
eventTrigger: {
  eventType: "an.event",
  eventFilter: {
    resource: "my-storage-bucket",
    appId: "12345",
  }
}
```

We now prefer eventFilter as a list:

```
eventTrigger: {
  eventType: "an.event",
  eventFilter: [
  {
    attribute: "resource",
    value: "my-storage-bucket",
  }.
  {
    attribute: "appId",
    value: "12345",
  }.
  ]
}
```

Most of the change in this PR is in tests. Few other minor changes I've squeezed in here:

1. Added a changelog entry for #1037
2. Deleted obsolete src/common/manifest.ts file
3. Small refactoring of alerts/crashlytics spec to make this migration easier.
@inlined inlined deleted the inlined.more-memory-and-regions branch March 28, 2022 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants