Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update grpc-java to 1.44.1 #3469

Closed
larssn opened this issue Feb 21, 2022 · 9 comments
Closed

Update grpc-java to 1.44.1 #3469

larssn opened this issue Feb 21, 2022 · 9 comments

Comments

@larssn
Copy link

larssn commented Feb 21, 2022

There's a fix to, what we consider a critical issue, with network detection on Android devices in 1.44.1. The PR and explanation can be found here: grpc/grpc-java#8855

Pretty sure this will fix several longstanding issues upstream in Flutterfire: firebase/flutterfire#6749 (comment)

I've been pestering your support department about this, and they assured me that you're aware of the issue. Well the fix is now here.

I'm hoping this isn't a dependency that is too difficult to update, and we can get this out of the door fairly quickly.

Thanks

@google-oss-bot
Copy link
Contributor

I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.

@argzdev
Copy link
Contributor

argzdev commented Feb 21, 2022

Thanks for the update, @larssn. I've made the change as needed, but I'll ask an engineer to take a closer look at it, if whether it's clear for merging or needs update.

@wu-hui wu-hui self-assigned this Feb 22, 2022
@argzdev
Copy link
Contributor

argzdev commented Feb 22, 2022

I've closed the previous PR to avoid redundancy. Please track the update of grpc version on PR #3473 instead. Thanks!

@wu-hui
Copy link
Contributor

wu-hui commented Feb 22, 2022

#3473 is merged.

It might take couple weeks for the next version to release..you can try getting a snapshot version or build from source directly if you want to use it.

@larssn
Copy link
Author

larssn commented Feb 23, 2022

@wu-hui Thank you so much!

It shouldn't be a problem to compile the source. Just not sure how to include the built aar's in flutterfire as they reference the BoM in their gradle files. If you have any tips for doing that I'd appreciate it.

Closed in #3473

@larssn
Copy link
Author

larssn commented Mar 10, 2022

@wu-hui Any idea when the next BoM will be released?

@dconeybe
Copy link
Contributor

We expect a release in the next week. Sorry that I can't give you a firmer date.

@larssn
Copy link
Author

larssn commented Mar 10, 2022

Thanks, that's perfect 👍

@dconeybe
Copy link
Contributor

FYI BoM 29.2.0 is now released. Please give it a try.

@firebase firebase locked and limited conversation to collaborators Mar 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants