From f5997e55eaafe1fc72cf03f67a3ccb0072f8814a Mon Sep 17 00:00:00 2001 From: Eric Gilmore Date: Mon, 4 Nov 2019 15:02:25 -0800 Subject: [PATCH 1/2] Tweaking docgen script to temporarily exclude an external type alias with which we are having difficulty. --- docgen/generate-docs.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docgen/generate-docs.js b/docgen/generate-docs.js index 86c4e3f34f..b0abb98c9d 100644 --- a/docgen/generate-docs.js +++ b/docgen/generate-docs.js @@ -40,7 +40,7 @@ const contentPath = path.resolve(`${__dirname}/content-sources/node`); const tempHomePath = path.resolve(`${contentPath}/HOME_TEMP.md`); const devsitePath = `/docs/reference/admin/node/`; -const firestoreExcludes = ['v1', 'v1beta1', 'setLogFunction']; +const firestoreExcludes = ['v1', 'v1beta1', 'setLogFunction','DocumentData']; const firestoreHtmlPath = `${docPath}/admin.firestore.html`; const firestoreHeader = `

Type aliases

From 5fc4a320fb9709be8fb9a9908bbcba8ca40b29a7 Mon Sep 17 00:00:00 2001 From: Eric Gilmore Date: Wed, 15 Jan 2020 11:25:33 -0800 Subject: [PATCH 2/2] Removing dupe comment per b/147492872. --- src/index.d.ts | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/index.d.ts b/src/index.d.ts index 5bce24b49b..5177647da2 100755 --- a/src/index.d.ts +++ b/src/index.d.ts @@ -154,8 +154,9 @@ declare namespace admin { serviceAccountId?: string; /** - * The ID of the service account to be used for signing custom tokens. This - * can be found in the `client_email` field of a service account JSON file. + * The name of the Google Cloud Storage bucket used for storing application data. + * Use only the bucket name without any prefixes or additions (do *not* prefix + * the name with "gs://"). */ storageBucket?: string;