fix(auth): Fixed the ability to discover the project ID when running on GCP managed environments #755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bojeil-google
suggested changes
Jan 10, 2020
src/utils/index.ts
Outdated
| @@ -56,14 +56,15 @@ export function addReadonlyGetter(obj: object, prop: string, value: any): void { | |||
| } | |||
|
|
|||
| /** | |||
| * Determines the Google Cloud project ID associated with a Firebase app by examining | |||
| * the Firebase app options, credentials and the local environment in that order. | |||
| * Returns the Google Cloud project ID associated with a Firebase app, if its explicitly | |||
test/unit/auth/credential.spec.ts
Outdated
| @@ -328,6 +329,47 @@ describe('Credential', () => { | |||
| }); | |||
| }); | |||
| }); | |||
|
|
|||
| it('should cache discovered project id', () => { | |||
| const expected = 'test-project-id'; | |||
There was a problem hiding this comment.
nit: Rename expected to expectedProjectId here and below.
|
@bojeil-google I've made the suggested changes. |
bojeil-google
approved these changes
Jan 10, 2020
lahirumaramba
approved these changes
Jan 10, 2020
hiranya911
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for auto discovering the project ID when running on Compute Engine, Cloud Run etc.
Verified by running a build on a Compute Engine instance.