Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(extensions): Add Extensions API #1960

Merged
merged 3 commits into from Nov 16, 2022
Merged

feat(extensions): Add Extensions API #1960

merged 3 commits into from Nov 16, 2022

Conversation

joehan
Copy link
Collaborator

@joehan joehan commented Oct 28, 2022

Adding the extensions namespace.

All code in this PR has been previously reviewed - extensions is just a launch branch

Testing

We've thoroughly tested this by packaging it and using it in multiple draft extensions.

API Changes

  • Approved in go/firex-admin-sdk

joehan and others added 2 commits September 19, 2022 15:51
* starting scaffolding

* Finish scaffolding extensions

* adding whitespace
* starting scaffolding

* Finish scaffolding extensions

* adding whitespace

* Implements Extensions namespace

* Expose extensions module

* fixing api-extractor by adding @internal

* Improve error handling

* lint

* Add jsdocsand api-extract

* merging

* style fixes from 1829

* style fix

* Addressing PR comments

* Clean up getRuntimeData

* typo fix

* in the tests as well

* PR fixes

* round 2 of fixes

* PR fixes

* Update src/extensions/extensions.ts

Co-authored-by: Kevin Cheung <kevinthecheung@users.noreply.github.com>

* Update src/extensions/extensions.ts

Co-authored-by: Kevin Cheung <kevinthecheung@users.noreply.github.com>

* Update src/extensions/extensions.ts

Co-authored-by: Kevin Cheung <kevinthecheung@users.noreply.github.com>

* Update src/extensions/extensions.ts

Co-authored-by: Kevin Cheung <kevinthecheung@users.noreply.github.com>

* Docs pass

* lint

* Fix test

Co-authored-by: Kevin Cheung <kevinthecheung@users.noreply.github.com>
@lahirumaramba lahirumaramba added release-note release:stage Stage a release candidate and removed release:stage Stage a release candidate labels Oct 28, 2022
Copy link
Member

@lahirumaramba lahirumaramba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@lahirumaramba lahirumaramba changed the title Add extensions namespace feat(extensions): Add extensions namespace Oct 28, 2022
@joehan joehan merged commit 623c02d into master Nov 16, 2022
@lahirumaramba lahirumaramba changed the title feat(extensions): Add extensions namespace feat(extensions): Add Extensions API Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants