Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(firestore): added missing 'ReadWriteTransactionOptions' export #1875

Conversation

naodya
Copy link
Contributor

@naodya naodya commented Aug 17, 2022

ReadWriteTransactionOptions is not exported from firebase-admin/firestore however available in @google-cloud/firestore

@lahirumaramba lahirumaramba self-requested a review October 17, 2022 21:29
@lahirumaramba
Copy link
Member

Hi @naodya, Thank you for your contribution! Could you run npm run api-extractor:local and add the new changes to the PR to fix the failing CIs, please?

@naodya
Copy link
Contributor Author

naodya commented Oct 17, 2022

Hi @naodya, Thank you for your contribution! Could you run npm run api-extractor:local and add the new changes to the PR to fix the failing CIs, please?

@lahirumaramba Done!

Copy link
Member

@lahirumaramba lahirumaramba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM!

@lahirumaramba lahirumaramba merged commit f596f2c into firebase:master Oct 28, 2022
@lahirumaramba lahirumaramba changed the title fix(firestore): added missing 'ReadWriteTransactionOptions' export (#1874) fix(firestore): added missing 'ReadWriteTransactionOptions' export Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants