add previous exception messages to plain text output #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can be disabled via `PlainTextHandler::addPreviousToOutput(false)` and adds lines between the exception and the trace containing the exception and line of creator. The method `Inspector::getFrames()` already appends all frames from the previous exceptions. So there is no need in adding the trace for each previous exception. IMO the test tests something that it should not test: the output of the line number. But that should be in a separate PR. I've at least added constants for the line numbers so that you only have to change them once for all tests.
staabm
reviewed
Dec 3, 2018
staabm
reviewed
Dec 3, 2018
|
I just realized how phpunit outputs the trace - they have some more line breaks: The trace for later exceptions is just a subset of the last but dividing the output with a line break and the Caused by keyword makes it easy to find specific exceptions with What do you think? |
|
Go for it. |
tflori
force-pushed
the
plaintext-previous
branch
from
bce5c5f
to
400cb5c
Compare
tflori
force-pushed
the
plaintext-previous
branch
from
400cb5c
to
54bf2df
Compare
staabm
reviewed
Dec 3, 2018
| /** | ||
| * @var bool | ||
| */ | ||
| private $addPreviousToOutput = true; |
There was a problem hiding this comment.
Why do we need this switch? Do you know a case where we dont want the previous exceptions?
There was a problem hiding this comment.
maybe someone don't want it in the logs. or they show it to the client and want to hide it there (for example the message could contain internal information that should only be visible to developers).
|
Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #608
Can be disabled via
PlainTextHandler::addPreviousToOutput(false)andadds lines between the exception and the trace containing the exception
and line of creator.
The method
Inspector::getFrames()already appends all frames from theprevious exceptions. So there is no need in adding the trace for each
previous exception.
IMO the test tests something that it should not test: the output of the
line number. But that should be in a separate PR. I've at least added
constants for the line numbers so that you only have to change them once
for all tests.