Bugfix/stacktrace is missing for haltable exceptions #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prisis
reviewed
Aug 22, 2017
src/Whoops/Exception/Inspector.php
Outdated
| * @return array | ||
| */ | ||
| protected function getTrace($e) | ||
| protected function getTrace(\Throwable $e) |
There was a problem hiding this comment.
you cant use \Throwable her it is only available in php 7.0
Vmak11
force-pushed
the
bugfix/stacktrace-is-missing-for-haltable-exceptions
branch
from
f4d733a
to
263ad8a
Compare
|
Could you add a unit test? |
…pty array when a full stack trace is available
Vmak11
force-pushed
the
bugfix/stacktrace-is-missing-for-haltable-exceptions
branch
from
263ad8a
to
2861a7e
Compare
|
Do you have any suggestions about how to unit test this as I'm not very familiar with Xdebug as well as setting up unit tests that require extensions to be installed. |
|
Add a unit test which reproduces the issue beeing fixed, add a "skip-condition" to not run it when xdebug is not loaded and assert via try/catch that the thrown exception will have a proper Stacktrace when provided to |
|
Would the following change achieve the same goal? |
denis-sokolov
added a commit
that referenced
this pull request
Jun 21, 2019
|
Hopefully fixed in 51c2de8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed I was missing a stack trace for a FatalThrowableError Exception that should have had one and found it was caused by returning an empty array for the stack trace due to a commit adding ability to get stack trace from xdebug for fatal errors:
c7ab118