Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop HHVM and PHP5.x support #504

Open
staabm opened this issue Jun 2, 2017 · 16 comments
Open

drop HHVM and PHP5.x support #504

staabm opened this issue Jun 2, 2017 · 16 comments

Comments

@staabm
Copy link
Contributor

staabm commented Jun 2, 2017

HHVM is used nearly anywhere and since php7 is a thing also doesnt has a real use-case anymore.

it was a great project to boost zend-php though.

we should drop hhvm and php5.x support and cleanup the code-base from hhvm workarounds (and drop hhvm ci).

do you guys agree? If so, I can provide a PR.

@jens1o
Copy link

jens1o commented Jun 2, 2017

I agree.

@denis-sokolov
Copy link
Collaborator

I have fixed Travis builds (now passing).

This would technically make us bump a major version, so unless you show big improvements, I’d rather not.

@prisis
Copy link
Contributor

prisis commented Jun 2, 2017

Only if we bump PHP to 7/7.1

@denis-sokolov
Copy link
Collaborator

What do you mean “bump”?

@prisis
Copy link
Contributor

prisis commented Jun 2, 2017

I mean dropping the supports for PHP 5 totally

@denis-sokolov
Copy link
Collaborator

Thanks for the explanation. Yep, fully agree.

@prisis
Copy link
Contributor

prisis commented Jun 2, 2017

Your welcome :)

@staabm
Copy link
Contributor Author

staabm commented Aug 29, 2017

@denis-sokolov please add a milestone, so we dont miss this when we will create a new major version.
(we dont create a new major version for this topic but in the future we will have a new major and then this could/should not be forgotten)

@staabm staabm changed the title drop HHVM support drop HHVM and PHP5.x support Aug 29, 2017
@nrueckmann
Copy link

Don't know if this issue is still open (last comment is 2 years old) but AFAIK the common consensus is that updating the version of dependencies is not a BC break. It's more like ending support for this specific dependency as no public interface changes.

@SvenRtbg
Copy link
Contributor

There is this discussion semver/semver#148 (comment)

@JefferyHus
Copy link

Isn't HHVM a runtime for Hack language? I don't believe dropping its support will be a good idea. For PHP version it's a must to stop supporting PHP 5.*

@Rarst
Copy link
Contributor

Rarst commented Mar 23, 2020

For trivia there are no longer any supported HHVM versions that support PHP code, the last one was 3.30 supported until November 2019. They went entirely Hack since, so there is nothing to support anymore.

@GrahamCampbell
Copy link
Contributor

Doesn't mean people aren't using it. PHP 5 is dead too...

@GrahamCampbell
Copy link
Contributor

and 7.0 and 7.1

@rjcalifornia
Copy link

Doesn't mean people aren't using it. PHP 5 is dead too...

Some legacy projects that are unable to upgrade are taking advantage of this tool. Great work!

@GrahamCampbell
Copy link
Contributor

Nothing stoping those projects using an old version of this, if we were to drop it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants