Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jackson JSONP Provider #111

Open
filip26 opened this issue Nov 26, 2020 · 9 comments
Open

Jackson JSONP Provider #111

filip26 opened this issue Nov 26, 2020 · 9 comments
Labels
enhancement New feature or request Stale

Comments

@filip26
Copy link
Owner

filip26 commented Nov 26, 2020

3/6 dependent libraries use jackson
1/6 gson

@filip26 filip26 added the enhancement New feature or request label Nov 27, 2020
@filip26 filip26 changed the title Direct Jackson support ? Jackson JSONP Provider Dec 12, 2020
@filip26
Copy link
Owner Author

filip26 commented Dec 12, 2020

@filip26 filip26 added this to the 1.1.0 milestone Dec 12, 2020
@filip26 filip26 removed this from the 1.1.0 milestone Jan 5, 2021
@github-actions
Copy link

github-actions bot commented Feb 5, 2021

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the Stale label Feb 5, 2021
@filip26 filip26 removed the Stale label Feb 5, 2021
@github-actions
Copy link

github-actions bot commented Mar 8, 2021

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the Stale label Mar 8, 2021
@filip26 filip26 removed the Stale label Mar 8, 2021
@github-actions
Copy link

github-actions bot commented Apr 8, 2021

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the Stale label Apr 8, 2021
@filip26 filip26 removed the Stale label Apr 8, 2021
@github-actions
Copy link

github-actions bot commented May 9, 2021

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the Stale label May 9, 2021
@filip26 filip26 removed the Stale label May 9, 2021
@github-actions
Copy link

github-actions bot commented Jun 9, 2021

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the Stale label Jun 9, 2021
@sigpwned
Copy link

It looks like the main action needed here is to implement a "bridge" JsonProvider class that uses Jackson to implement JSON-P. I think that's probably a Jackson concern. It's worth proposing it on Jackson's future ideas board. I'll link back here when I have the chance to make the proposal.

@filip26
Copy link
Owner Author

filip26 commented Aug 27, 2022

Hi @sigpwned
having Jackson implementing JsonProvider would be great. Thanks

@edouardhue
Copy link

It sound like the Jackson project does not want to implement JSON-P. The question was raised a long time ago and the JSR was disregarded. almost ten years and several new JSRs later, Jackson still does not implement JSON-P, I believe they never will.

Jackson provides a Jakarta JSON datatype that makes it rather simple to convert a Jackson tree to a Jakarta tree.

var jacksonNode = JsonNodeFactory.instance.objectNode();
var mapper = JsonMapper.builder().addModule(new JSONPModule()).build();
var jakartaNode = mapper.convertValue(jacksonNode, JsonObject.class);

Still, it would be nice not to have to convert, and Jackson remains widely used. Some libraries (like Jersey) support several JSON providers, but this may be tedious implementing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Stale
Projects
None yet
Development

No branches or pull requests

3 participants