Skip to content
This repository has been archived by the owner on Jun 6, 2023. It is now read-only.

Enforced static analysis of probable bugs (e.g. ignored errors) #456

Closed
anorth opened this issue Jun 10, 2020 · 3 comments · Fixed by #458
Closed

Enforced static analysis of probable bugs (e.g. ignored errors) #456

anorth opened this issue Jun 10, 2020 · 3 comments · Fixed by #458
Assignees
@ZenGround0
Labels
cleanup Technical debt recovery and other cleanup work code-ready Ready for implementation, with clear path P1 High priority, required for basic network functionality and growth
Milestone
💛 Feature Freeze

Comments

@anorth
Copy link
Member

anorth commented Jun 10, 2020

The linting currently enforced on the project is too weak. For example, there are a bunch of cases of ignored error return values which are easy to miss in development and review (e.g. #309, with no fewer than three approvals).

Implement much stricter static analysis and enforce increasing strictness in CI.
@anorth anorth added P1 High priority, required for basic network functionality and growth code-ready Ready for implementation, with clear path cleanup Technical debt recovery and other cleanup work labels Jun 10, 2020
@whyrusleeping whyrusleeping added this to the Feature Freeze milestone Jun 11, 2020
@ZenGround0 ZenGround0 self-assigned this Jun 11, 2020
@ZenGround0 ZenGround0 mentioned this issue Jun 11, 2020
Merged
@ZenGround0
Copy link
Contributor

I'm reproducing the lack of err check. The weird thing is that CI appears to think it is doing the right thing: Active 10 linters: [deadcode errcheck gosimple govet ineffassign staticcheck structcheck typecheck unused varcheck]

@ZenGround0
Copy link
Contributor

aha: things in directories called "builtin" are skipped by default.

@anorth
Copy link
Member Author

anorth commented Jun 12, 2020

🤦

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ZenGround0 ZenGround0

Labels
cleanup Technical debt recovery and other cleanup work code-ready Ready for implementation, with clear path P1 High priority, required for basic network functionality and growth
Projects
None yet
Milestone
💛 Feature Freeze
Development

Successfully merging a pull request may close this issue.

Stricter Linting filecoin-project/specs-actors
3 participants
@anorth @whyrusleeping @ZenGround0