TestCCUpgrade is flaky

[vyzo]

See https://app.circleci.com/pipelines/github/filecoin-project/lotus/8846/workflows/aa7988b5-a336-462d-af3a-7d5e0bda2c00/jobs/54713

[Stebalien]

It's now flaky for a different reason. Specifically, filecoin-project/go-fil-markets#614.

Basically, payment channel creation fails because we create the payment channel create message on one side of an upgrade, then execute the message on the other.

The fix is to either:

1. Fix the underlying issue (difficult and not likely to be worth it at the moment).
2. Instead of just hard-coding the upgrade heights then assuming the deal creation will happen at the right spot, wait until the upgrade has happened (for the epoch 560 case, at least) then make the deal.

[Stebalien]

Alternatively, stop abusing this test? I mean, we're testing CC upgrades, CC upgrades over network upgrades, and retrieval deals.

[rjan90]

Hey!

Closing this issue as CC-upgrades / mark-for-upgrade has been deprecated as of Lotus 1.15.0.

[Stebalien]

It has been deprecated in lotus, but the tests are still there and are still flaky (causing CI to fail, etc.).

E.g. https://app.circleci.com/pipelines/github/filecoin-project/lotus/20181/workflows/e0da81ad-3ae0-4e90-96b3-04ba010ceb0a/jobs/413587

[rjan90]

Closing this issue since it seems like TestCCUpgrade is not flaky anymore. We will open a new issue, if we see it being flaky in master again!