Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:state:Ignore market balance after nv23 #11976

Merged
merged 8 commits into from May 13, 2024
Merged

feat:state:Ignore market balance after nv23 #11976

merged 8 commits into from May 13, 2024

Conversation

ZenGround0
Copy link
Contributor

Related Issues

Closes #11921

Proposed Changes

Drop builtin market calculation from locked balance calculation after nv23

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • If the PR affects users (e.g., new feature, bug fix, system requirements change), update the CHANGELOG.md and add details to the UNRELEASED section.
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

chain/stmgr/supply.go Outdated Show resolved Hide resolved
chain/stmgr/supply.go Outdated Show resolved Hide resolved
@ZenGround0 ZenGround0 requested a review from rvagg May 11, 2024 20:08
itests/supply_test.go Outdated Show resolved Hide resolved
Copy link
Member

@rvagg rvagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍, although the need for a difference tolerance seems a bit concerning without an explanation

@ZenGround0 ZenGround0 enabled auto-merge (squash) May 13, 2024 14:37
@ZenGround0 ZenGround0 disabled auto-merge May 13, 2024 14:38
@ZenGround0 ZenGround0 force-pushed the feat/fip-065 branch 2 times, most recently from a759d71 to 0df84d0 Compare May 13, 2024 20:07
@anorth
Copy link
Member

anorth commented May 13, 2024

Thanks!

@ZenGround0 ZenGround0 enabled auto-merge (squash) May 13, 2024 20:31
@ZenGround0 ZenGround0 merged commit 84b08fc into master May 13, 2024
188 checks passed
@ZenGround0 ZenGround0 deleted the feat/fip-065 branch May 13, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement FIP 0065
4 participants