Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle payment chanel ready to go #677

Merged
merged 1 commit into from Feb 16, 2022

Conversation

hannahhoward
Copy link
Collaborator

Goals

This is a companion PR to filecoin-project/lotus#7883 to remove hacky code from the RetrievalClientAdapter.

It enables that code to run without changes but support the new pre-funding the payment channel manager

Implementation

  • if GetOrCreatePaymentChannel returns a cid.Undef for the msgCID, treat it as ready to go

handle GetOrCreatePaymentChannel returns cid.Undef as payment channel being ready to use
@codecov-commenter
Copy link

Codecov Report

Merging #677 (e360fa1) into master (8d45bb7) will decrease coverage by 0.14%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #677      +/-   ##
==========================================
- Coverage   59.81%   59.68%   -0.13%     
==========================================
  Files          64       64              
  Lines        5260     5262       +2     
==========================================
- Hits         3146     3140       -6     
- Misses       1782     1790       +8     
  Partials      332      332              
Impacted Files Coverage Δ
retrievalmarket/impl/clientstates/client_fsm.go 66.93% <ø> (ø)
retrievalmarket/impl/clientstates/client_states.go 95.32% <100.00%> (+0.08%) ⬆️
retrievalmarket/events.go 0.00% <0.00%> (-80.00%) ⬇️
retrievalmarket/dealstatus.go 0.00% <0.00%> (-80.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c03723a...e360fa1. Read the comment docs.

@hannahhoward hannahhoward merged commit 5e87024 into master Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants