Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

market fsm/storage deal status should support SnapDeal #662

Open
jennijuju opened this issue Jan 13, 2022 · 2 comments
Open

market fsm/storage deal status should support SnapDeal #662

jennijuju opened this issue Jan 13, 2022 · 2 comments

Comments

@jennijuju
Copy link
Member

Fip 0019 introduces SnapDeal that allows SP to put deal into cc sectors by doing ProveReplicaUpdate without reseal the sector.

see the sector fsm here https://github.com/filecoin-project/lotus/blob/d645c5fbabe2c087c21058d7a5eeda09da7a0f0a/extern/storage-sealing/fsm.go#L137-L174

and storage deal status should reflect that

StorageDealAwaitingPreCommit: "a few minutes",
StorageDealSealing: "a few hours",

@jacobheun
Copy link
Contributor

@jennijuju can you clarify what outcome is needed here? Is this for storage deals list? Not quite sure what end state we're hoping to expose here.

@jennijuju
Copy link
Member Author

jennijuju commented Feb 3, 2022

yes. ...opmpcyjq 2890 StorageDealAwaitingPreCommit t12j6glkr4vetge3iqw5vxwl4zubjsxlgt4c5iiji 2MiB 0 FIL 603647

for SnapDeals, there is no precommit or prove commit(sealing), but only a ProveReplicaUpdate step - this may take between 16min to an hour based on the hardware.

I would suggest to add a state called something likeStorageDealSnapping that represents the sealing states https://github.com/filecoin-project/lotus/blob/51643caf60a0f81445b4f22fd829aad0e61b7da4/extern/storage-sealing/fsm.go#L150-L161 and proceed to StorageDealActive once https://github.com/filecoin-project/lotus/blob/51643caf60a0f81445b4f22fd829aad0e61b7da4/extern/storage-sealing/fsm.go#L162 is sent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants