ReadOnlyBlockstore in retrieval provider appears to track stores by deal id only, which is potentially non-unique

[hannahhoward]

Hello:

I noticed we have:
https://github.com/filecoin-project/go-fil-markets/blob/master/retrievalmarket/impl/provider_environments.go#L138
and
https://github.com/filecoin-project/go-fil-markets/blob/master/retrievalmarket/impl/provider_environments.go#L261

It looks like you track your various DagShards in the retrieval provider by the deal only. While using a deal ID generated from time.Now() makes this less likely, deal ID is NOT gauranteed to be unique. For unique ID, you need to combine DealID + peer.ID -- which is why we use that combination for ProviderDealId, the value we index stored retrieval deals by elsewhere.

[dirkmc]

Agreed we need to fix it 👍
Thanks for the catch 🎣