Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storage Provider creates informative names for deal data staged via the FileStore #583

Open
frrist opened this issue Jul 21, 2021 · 0 comments · May be fixed by #584
Open

Storage Provider creates informative names for deal data staged via the FileStore #583

frrist opened this issue Jul 21, 2021 · 0 comments · May be fixed by #584
Labels
enhancement New feature or request

Comments

@frrist
Copy link
Member

frrist commented Jul 21, 2021

Background

This issue is motivated by filecoin-project/lotus#5291. Users have requested that the temporary files created by the FileStore have a more informative name when they are staged before being passed off to the Storage Miner Module.

Where to Begin

tempfi, err := p.fs.CreateTemp()
if err != nil {
return xerrors.Errorf("failed to create temp file for data import: %w", err)
}
cleanup := func() {
_ = tempfi.Close()
_ = p.fs.Delete(tempfi.Path())
}

@frrist frrist added the enhancement New feature or request label Jul 21, 2021
@frrist frrist changed the title Storage Provider creates imformative names for deal data staged via the FileStore Storage Provider creates informative names for deal data staged via the FileStore Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant