Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

instance.roundState(round) is a (minor) DoS vector #208

Open
Tracked by #12
Stebalien opened this issue May 10, 2024 · 1 comment
Open
Tracked by #12

instance.roundState(round) is a (minor) DoS vector #208

Stebalien opened this issue May 10, 2024 · 1 comment
Labels
bug Something isn't working gossipbft Relates to core GossipPBFT protocol

Comments

@Stebalien
Copy link
Member

IIRC, the plan to avoid storing arbitrary messages was to:

  1. Store at most one "quality" value from every miner.
  2. ignore all messages from future rounds that lack justification from a prior round (again, at most once per miner).

However, roundState implicitly allocates a round object before we even look at the message. It's possible for a miner to repeatedly send the same quality message but with different rounds, forcing us to allocate a bunch of round states.

This will probably get fixed when we implement the above but... it's a subtle implicit allocation that's easily overlooked, so I wanted to write this down so we don't forget.

@Stebalien
Copy link
Member Author

Part of #12.

@jennijuju jennijuju added gossipbft Relates to core GossipPBFT protocol bug Something isn't working labels May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working gossipbft Relates to core GossipPBFT protocol
Projects
Status: Todo
Development

No branches or pull requests

3 participants