You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
IIRC, the plan to avoid storing arbitrary messages was to:
Store at most one "quality" value from every miner.
ignore all messages from future rounds that lack justification from a prior round (again, at most once per miner).
However, roundState implicitly allocates a round object before we even look at the message. It's possible for a miner to repeatedly send the same quality message but with different rounds, forcing us to allocate a bunch of round states.
This will probably get fixed when we implement the above but... it's a subtle implicit allocation that's easily overlooked, so I wanted to write this down so we don't forget.
The text was updated successfully, but these errors were encountered:
IIRC, the plan to avoid storing arbitrary messages was to:
However,
roundState
implicitly allocates a round object before we even look at the message. It's possible for a miner to repeatedly send the same quality message but with different rounds, forcing us to allocate a bunch of round states.This will probably get fixed when we implement the above but... it's a subtle implicit allocation that's easily overlooked, so I wanted to write this down so we don't forget.
The text was updated successfully, but these errors were encountered: