Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid proposing Values with more than CHAIN_MAX_LEN #203

Closed
Stebalien opened this issue May 8, 2024 · 0 comments · Fixed by #206
Closed

Avoid proposing Values with more than CHAIN_MAX_LEN #203

Stebalien opened this issue May 8, 2024 · 0 comments · Fixed by #206
Assignees

Comments

@Stebalien
Copy link
Member

Right now, I believe the client needs to avoid telling go-f3 about more than 99 (CHAIN_MAX_LEN-1) tipsets. Otherwise, we'll attempt to propose more than 100 tipsets in a single instance and fail the validity check.

We need to implement a rate-limit and, IMO, the right place to put this is in go-f3 itself. I.e., let the client tell go-f3 about as many tipsets as it wants but have go-f3 take chunks of at most CHAIN_MAX_LEN tipsets at a time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants