Avoid proposing chains that are longer than max. #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
reviewed
May 10, 2024
gpbft/participant.go
Outdated
| @@ -145,6 +145,8 @@ func (p *Participant) ReceiveAlarm() (err error) { | |||
|
|
|||
| func (p *Participant) beginInstance() error { | |||
| chain, power, beacon := p.host.GetCanonicalChain() | |||
| // Limit length of the chain to be proposed. | |||
| chain = chain.Prefix(CHAIN_MAX_LEN - 1) | |||
There was a problem hiding this comment.
The chain includes the base, right? This should be CHAIN_MAX_LEN in that case (no -1).
There was a problem hiding this comment.
(it would be nice to assert that the base matches the end of our previous proposal...
There was a problem hiding this comment.
The Prefix method adds one: Prefix(0) is the base chain. Yes perhaps this isn't the ideal semantics, but it makes more sense at some other call sites. I wouldn't object to you overhauling that in another PR, but it's below my threshold at the moment.
There was a problem hiding this comment.
Or did you mean that the max length should be CHAIN_MAX_LEN tips plus one for the base?
There was a problem hiding this comment.
Ah, no. I misunderstood prefix. LGTM.
anorth
force-pushed
the
anorth/max-chain
branch
2 times, most recently
from
15198a7
to
cea0df8
Compare
Stebalien
approved these changes
May 14, 2024
Kubuxu
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #203