Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Configurable Instance Number in Simulations for gPBFT Package #195

Open
masih opened this issue May 7, 2024 · 1 comment
Open

Comments

@masih
Copy link
Member

masih commented May 7, 2024

Simulations always start at instance zero. Most tests also implicitly assume this. But the gPBFT package allows a user to start at a non-zero instance.

Implement the ability to configure instance number in simulations and add additional tests to exercise relevant code.

@anorth
Copy link
Member

anorth commented May 7, 2024

I think this was posted in response to a comment I made in code review, but I don't think this is worth doing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

2 participants