Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design questions left for FIP #177

Open
4 of 6 tasks
ranchalp opened this issue Apr 24, 2024 · 7 comments
Open
4 of 6 tasks

Design questions left for FIP #177

ranchalp opened this issue Apr 24, 2024 · 7 comments

Comments

@ranchalp
Copy link
Collaborator

ranchalp commented Apr 24, 2024

Left design questions, only to be marked as done once they are in a PR for the FIP at least.

Tasks

@ranchalp
Copy link
Collaborator Author

ranchalp commented Apr 24, 2024

i. undergoing discussion, to be added in a different Draft PR later on. This Draft PR should contain ii. too (at least the part of ii. relating #176 ).

iii. and iv. added to the following Draft PR

v. to be tracked by @Stebalien

vi. to be discussed, but updates made to the same Draft PR as iii. and iv.

@ranchalp
Copy link
Collaborator Author

For ii. what is the state of the @Stebalien @Kubuxu ?

@jsoares
Copy link
Member

jsoares commented Apr 26, 2024

Talked to @Kubuxu; let's wait until early next week and see if @Stebalien is back; if not, @Kubuxu will pick up specifying 2 (FDEP) and 5 (ECTipset format) for the FIP.

@ranchalp
Copy link
Collaborator Author

i. is optimistically submitted to a dedicated Draft PR but discussion is still open.

@jennijuju
Copy link
Member

@anorth @masih can we do a ✅ practice to see whats left to do, i assume that determines when we can move FIP to last call?

@masih
Copy link
Member

masih commented May 23, 2024

I am not sure about task No. 6 Finish off test cases in FIP (seems to have completed here), but the remaining subtasks seem to be implementation related not FIP related?

Should the FIP go as far as documenting when to start an instance or pull certificates? They seem to be more on the implementation side than algorithmic part. Perhaps a paragraph on suggestions would suffice if the concensus is that the FIP should include them.

Apart from that I think the FIP could move to last call, unless there is something that I have missed.

@anorth thoughts?

@anorth
Copy link
Member

anorth commented May 23, 2024

Yeah I think we're almost done with these design questions. I think it would be appropriate for the FIP to mention something about when to pull certificates, although I agree the policy is largely up to the client.

I would still be a bit hesitant to say the FIP is ready for last call right now, though. Things are still changing and we have yet to do a pass pushing implementation things back into the FIP - we need to be about done with implementation for that. We also have audits to review and I suspect we might find something there too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

6 participants